Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 342493002: Set target_arch to ia32 instead of x86_64 on 32bit userland 64bit kernel systems. (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 6 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Set target_arch to ia32 instead of x86_64 on 32bit userland 64bit kernel systems. BUG=385472, 368384 R=bradnelson@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -3 lines 0 comments Download
A build/detect_nacl_host_arch.py View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
(the python script is the same script that chromium uses)
6 years, 6 months ago (2014-06-17 17:53:26 UTC) #1
bradn
lgtm
6 years, 6 months ago (2014-06-17 20:53:57 UTC) #2
Nico
6 years, 6 months ago (2014-06-17 20:55:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698