Source/core/editing/PlainTextRange.cpp - Issue 342483002: The length of a TextIterator containing replaced element is at least 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/PlainTextRange.cpp

Issue 342483002: The length of a TextIterator containing replaced element is at least 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix style issues. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt ('k') | Source/core/editing/TextIterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/PlainTextRange.cpp

diff --git a/Source/core/editing/PlainTextRange.cpp b/Source/core/editing/PlainTextRange.cpp

index 1ebc8f4716fb1799a702f0b3bebb88d5e8f3b1a4..957e1c25e15ba983708734b231a8f97200f6afaa 100644

--- a/Source/core/editing/PlainTextRange.cpp

+++ b/Source/core/editing/PlainTextRange.cpp

@@ -110,9 +110,10 @@ PassRefPtrWillBeRawPtr<Range> PlainTextRange::createRangeFor(const ContainerNode

// Fix textRunRange->endPosition(), but only if foundStart || foundEnd, because it is only

// in those cases that textRunRange is used.

if (foundEnd) {

- // FIXME: This is a workaround for the fact that the end of a run is often at the wrong

- // position for emitted '\n's.

- if (len == 1 && it.characterAt(0) == '\n') {

+ // FIXME: This is a workaround for the fact that the end of a run

+ // is often at the wrong position for emitted '\n's or if the

+ // renderer of the current node is a replaced element.

+ if (len == 1 && (it.characterAt(0) == '\n' || it.isInsideReplacedElement())) {

scope.document().updateLayoutIgnorePendingStylesheets();

it.advance();

if (!it.atEnd()) {