LayoutTests/editing/execCommand/remove-format-iframe-in-button.html - Issue 342483002: The length of a TextIterator containing replaced element is at least 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/remove-format-iframe-in-button.html

Issue 342483002: The length of a TextIterator containing replaced element is at least 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script type="text/javascript">
	Yuta Kitamura 2014/06/18 03:14:38 I generally recommend NOT indenting nested HTML el I generally recommend NOT indenting nested HTML elements, since they can be very deeply nested and can harm readability. (JavaScript should be indented as usual.)
	5

	6 function runTest() {

	7 if (window.testRunner)

	8 testRunner.dumpAsText();

	9

	10 document.designMode="on";

	11 var button = document.getElementById('test');
	Yuta Kitamura 2014/06/18 03:14:38 This variable seems unused. This variable seems unused.
	12 document.execCommand("SelectAll");

	13 document.execCommand("RemoveFormat");

	14 Markup.dump("test");

	15 }

	16 </script>

	17
	Yuta Kitamura 2014/06/18 03:14:38 Unnecessary blank line. Unnecessary blank line.
	18 </head>

	19
	Yuta Kitamura 2014/06/18 03:14:38 Ditto. Ditto.
	20 <body onload="runTest()">

	21 <script type="text/javascript" src="../../resources/dump-as-markup.js"></scr ipt>

	22 <button id="test">
	Yuta Kitamura 2014/06/18 03:14:38 Weird indentation. Weird indentation.
	23 <iframe></iframe>

	24 </button>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/remove-format-iframe-in-button-expected.txt » ('j') | Source/core/editing/TextIterator.h » ('J')