Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: runtime/vm/object.h

Issue 342473006: Don't add the catch frame at a rethrow to the stacktrace. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: move skipping logic to stacktrace::append Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_OBJECT_H_ 5 #ifndef VM_OBJECT_H_
6 #define VM_OBJECT_H_ 6 #define VM_OBJECT_H_
7 7
8 #include <limits> 8 #include <limits>
9 #include "include/dart_api.h" 9 #include "include/dart_api.h"
10 #include "platform/assert.h" 10 #include "platform/assert.h"
(...skipping 6763 matching lines...) Expand 10 before | Expand all | Expand 10 after
6774 6774
6775 RawCode* CodeAtFrame(intptr_t frame_index) const; 6775 RawCode* CodeAtFrame(intptr_t frame_index) const;
6776 void SetCodeAtFrame(intptr_t frame_index, const Code& code) const; 6776 void SetCodeAtFrame(intptr_t frame_index, const Code& code) const;
6777 6777
6778 RawSmi* PcOffsetAtFrame(intptr_t frame_index) const; 6778 RawSmi* PcOffsetAtFrame(intptr_t frame_index) const;
6779 void SetPcOffsetAtFrame(intptr_t frame_index, const Smi& pc_offset) const; 6779 void SetPcOffsetAtFrame(intptr_t frame_index, const Smi& pc_offset) const;
6780 void SetCatchStacktrace(const Array& code_array, 6780 void SetCatchStacktrace(const Array& code_array,
6781 const Array& pc_offset_array) const; 6781 const Array& pc_offset_array) const;
6782 void set_expand_inlined(bool value) const; 6782 void set_expand_inlined(bool value) const;
6783 6783
6784 void Append(const Array& code_list, const Array& pc_offset_list) const; 6784 void Append(const Array& code_list,
6785 const Array& pc_offset_list,
6786 const intptr_t offset) const;
siva 2014/06/25 22:46:12 I would rename 'offset' to 'start_index'
rmacnak 2014/06/25 23:00:43 That's better.
6785 6787
6786 static intptr_t InstanceSize() { 6788 static intptr_t InstanceSize() {
6787 return RoundedAllocationSize(sizeof(RawStacktrace)); 6789 return RoundedAllocationSize(sizeof(RawStacktrace));
6788 } 6790 }
6789 static RawStacktrace* New(const Array& code_array, 6791 static RawStacktrace* New(const Array& code_array,
6790 const Array& pc_offset_array, 6792 const Array& pc_offset_array,
6791 Heap::Space space = Heap::kNew); 6793 Heap::Space space = Heap::kNew);
6792 6794
6793 RawString* FullStacktrace() const; 6795 RawString* FullStacktrace() const;
6794 6796
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
7132 7134
7133 7135
7134 RawObject* MegamorphicCache::GetTargetFunction(const Array& array, 7136 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
7135 intptr_t index) { 7137 intptr_t index) {
7136 return array.At((index * kEntryLength) + kTargetFunctionIndex); 7138 return array.At((index * kEntryLength) + kTargetFunctionIndex);
7137 } 7139 }
7138 7140
7139 } // namespace dart 7141 } // namespace dart
7140 7142
7141 #endif // VM_OBJECT_H_ 7143 #endif // VM_OBJECT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698