Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 342473003: Use isProgram method to detect Program events (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Use isProgram method to detect Program events The method allows to avoid direct access to implementation specific RecordType enum. BUG=361045 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePresentationModel.js View 1 chunk +7 lines, -8 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
6 years, 6 months ago (2014-06-17 13:22:59 UTC) #1
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-17 13:23:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/342473003/1
6 years, 6 months ago (2014-06-17 13:23:33 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 13:23:34 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-17 13:23:35 UTC) #5
loislo
lgtm
6 years, 6 months ago (2014-06-17 13:47:12 UTC) #6
yurys
6 years, 6 months ago (2014-06-17 13:53:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r176314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698