Adding EME browsertests for codecs with profile extension

Adding browsertests for codecs with profile extension

MP4 codecs have profile parameter suffixed in them. Earlier chromium used
to strip away that parameter. After r277386, these parameters are considered
and handled differently. This patch adds some more browsertests for codecs
with profile parameter, for EMEs, so as to have robust testing framework.

BUG=53193
TEST=out/Release/browser_tests --gtest_filter=EncryptedMediaIsTypeSupported*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278670

[amogh.bihani, 2014-06-17 12:39:54]

As discussed in https://codereview.chromium.org/254983006/ I am adding browsert
tests for extended codecs.
PTAL.

[ddorwin, 2014-06-17 22:03:25]

LGTM with comment. Please also update the description to note that these are EME
browser tests.

https://codereview.chromium.org/342473002/diff/1/chrome/browser/media/encrypt...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/342473002/diff/1/chrome/browser/media/encrypt...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:985:
EXPECT_WVAVC1(IsSupportedKeySystemWithMediaMimeType(
EXPECT_WVAVC1 here and below.

[amogh.bihani, 2014-06-18 03:37:04]

https://codereview.chromium.org/342473002/diff/1/chrome/browser/media/encrypt...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/342473002/diff/1/chrome/browser/media/encrypt...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:985:
EXPECT_WVAVC1(IsSupportedKeySystemWithMediaMimeType(
On 2014/06/17 22:03:25, ddorwin wrote:
> EXPECT_WVAVC1 here and below.

Im sorry, I dont get it. It is already EXPECT_WVAVC1.

[ddorwin, 2014-06-18 17:07:22]

https://codereview.chromium.org/342473002/diff/1/chrome/browser/media/encrypt...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/342473002/diff/1/chrome/browser/media/encrypt...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:985:
EXPECT_WVAVC1(IsSupportedKeySystemWithMediaMimeType(
On 2014/06/18 03:37:04, amogh.bihani wrote:
> On 2014/06/17 22:03:25, ddorwin wrote:
> > EXPECT_WVAVC1 here and below.
> 
> Im sorry, I dont get it. It is already EXPECT_WVAVC1.

Sorry, I copied the wrong line above. I meant EXPECT_WVAVC1AAC.

[amogh.bihani, 2014-06-19 03:41:59]

The CQ bit was checked by amogh.bihani@samsung.com

[commit-bot: I haz the power, 2014-06-19 03:44:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/342473002/20001

[amogh.bihani, 2014-06-19 06:14:43]

The CQ bit was unchecked by amogh.bihani@samsung.com

[amogh.bihani, 2014-06-19 10:28:01]

Some tests are failing, which I am unable to contemplate.
Please refer to my comments (and for logs you may refer to
linux_chromium_chromeos_rel).

https://codereview.chromium.org/342473002/diff/40001/chrome/browser/media/enc...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/342473002/diff/40001/chrome/browser/media/enc...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:590:
"audio/mp4", avc3_extended_and_aac_codecs(), kPrefixedClearKey));
It seems counter-intutive that this test fails when test on line 582 and line
586 pass. Ditto for test on line 802.
However, test on line 1036 passes!
Could you please tell me whether this is expected behaviour?

[ddorwin, 2014-06-19 20:15:44]

It's a test code bug.

https://codereview.chromium.org/342473002/diff/40001/chrome/browser/media/enc...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/342473002/diff/40001/chrome/browser/media/enc...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:140:
avc1_extended_and_aac_codecs_.push_back("avc3.64001F");
s/avc1/avc3/ here and below.

https://codereview.chromium.org/342473002/diff/40001/chrome/browser/media/enc...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:590:
"audio/mp4", avc3_extended_and_aac_codecs(), kPrefixedClearKey));
On 2014/06/19 10:28:01, amogh.bihani wrote:
> It seems counter-intutive that this test fails when test on line 582 and line
> 586 pass. Ditto for test on line 802.
> However, test on line 1036 passes!
> Could you please tell me whether this is expected behaviour?

1036 passes because all Widevine results are false for Chromium builds.

[amogh.bihani, 2014-06-20 03:05:20]

The CQ bit was checked by amogh.bihani@samsung.com

[amogh.bihani, 2014-06-20 03:05:28]

Thanks :)

https://codereview.chromium.org/342473002/diff/40001/chrome/browser/media/enc...
File chrome/browser/media/encrypted_media_istypesupported_browsertest.cc
(right):

https://codereview.chromium.org/342473002/diff/40001/chrome/browser/media/enc...
chrome/browser/media/encrypted_media_istypesupported_browsertest.cc:140:
avc1_extended_and_aac_codecs_.push_back("avc3.64001F");
On 2014/06/19 20:15:43, ddorwin wrote:
> s/avc1/avc3/ here and below.

Oops!
Thanks :)

[commit-bot: I haz the power, 2014-06-20 03:07:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/342473002/60001

[commit-bot: I haz the power, 2014-06-20 11:06:09]

Change committed as 278670