Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Issue 342463002: Retire now-unused WorkerGlobalScope subobject accessors. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
Reviewers:
haraken, adamk
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Retire now-unused WorkerGlobalScope subobject accessors. R=haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M Source/core/workers/WorkerGlobalScope.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-17 12:03:09 UTC) #1
haraken
LGTM.
6 years, 6 months ago (2014-06-17 12:28:52 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-17 12:36:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/342463002/1
6 years, 6 months ago (2014-06-17 12:37:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 14:28:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18077)
6 years, 6 months ago (2014-06-17 14:28:35 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-17 14:29:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/342463002/1
6 years, 6 months ago (2014-06-17 14:30:59 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 15:28:56 UTC) #9
Message was sent while issue was closed.
Change committed as 176320

Powered by Google App Engine
This is Rietveld 408576698