Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: Source/devtools/front_end/ui/SettingsUI.js

Issue 342443002: [DevTools] Ability to emulate touch or user agent, even when device emulation is turned off. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ui/SettingsUI.js
diff --git a/Source/devtools/front_end/ui/SettingsUI.js b/Source/devtools/front_end/ui/SettingsUI.js
index 34e59af77c7ef6bb14cdbaa3d6db51499a5cf1cb..3a869a9f193d89f97041b05f012420c5338e58cd 100644
--- a/Source/devtools/front_end/ui/SettingsUI.js
+++ b/Source/devtools/front_end/ui/SettingsUI.js
@@ -168,10 +168,9 @@ WebInspector.SettingsUI.createSettingInputField = function(label, setting, numer
* @param {!WebInspector.Setting} setting
* @param {number=} maxLength
* @param {string=} width
- * @param {!WebInspector.Setting=} toggleSetting
* @param {string=} defaultText
*/
-WebInspector.SettingsUI.createSettingLabel = function(label, setting, maxLength, width, toggleSetting, defaultText)
+WebInspector.SettingsUI.createSettingLabel = function(label, setting, maxLength, width, defaultText)
{
var p = document.createElement("p");
var labelElement = p.createChild("span");
@@ -183,14 +182,12 @@ WebInspector.SettingsUI.createSettingLabel = function(label, setting, maxLength,
if (width)
p.style.width = width;
- if (toggleSetting)
- toggleSetting.addChangeListener(onSettingChange);
setting.addChangeListener(onSettingChange);
onSettingChange();
function onSettingChange()
{
- var text = toggleSetting && !toggleSetting.get() ? (defaultText || "") : setting.get();
+ var text = setting.get() || defaultText;
spanElement.title = text;
if (maxLength && text.length > maxLength)
text = text.substring(0, maxLength - 2) + "...";

Powered by Google App Engine
This is Rietveld 408576698