Issue 342433005: Remove incorrect use of std:: in chromedriver_server.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342433005: Remove incorrect use of std:: in chromedriver_server.cc. (Closed)

Created:
6 years, 6 months ago by earthdok

Modified:
6 years, 6 months ago

Reviewers:
stgao

CC:
chromium-reviews, stgao

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove incorrect use of std:: in chromedriver_server.cc. setlocale() isn't part of the std:: namespace. This was breaking libc++ builds. BUG=318770 TBR=stgao@chromium.org NOTRY=true TEST=built with libc++ and libstdc++ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277805

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/chromedriver/server/chromedriver_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/342433005/1

6 years, 6 months ago (2014-06-17 17:58:25 UTC) #3

Message was sent while issue was closed.

Change committed as 277805