Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: Source/devtools/front_end/ResponsiveDesignView.js

Issue 342433002: DevTools: cleanup Network.emulateNetworkConditions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/elements/OverridesView.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @implements {WebInspector.OverridesSupport.PageResizer} 8 * @implements {WebInspector.OverridesSupport.PageResizer}
9 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder 9 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder
10 */ 10 */
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 var networkCheckbox = fieldsetElement.createChild("label"); 449 var networkCheckbox = fieldsetElement.createChild("label");
450 networkCheckbox.textContent = WebInspector.UIString("Network"); 450 networkCheckbox.textContent = WebInspector.UIString("Network");
451 fieldsetElement.appendChild(WebInspector.overridesSupport.createNetworkT hroughputSelect(document)); 451 fieldsetElement.appendChild(WebInspector.overridesSupport.createNetworkT hroughputSelect(document));
452 452
453 var separator = networkSection.createChild("div", "responsive-design-sec tion-separator"); 453 var separator = networkSection.createChild("div", "responsive-design-sec tion-separator");
454 454
455 // User agent. 455 // User agent.
456 var userAgentElement = networkSection.createChild("div", "responsive-des ign-suite").createChild("div"); 456 var userAgentElement = networkSection.createChild("div", "responsive-des ign-suite").createChild("div");
457 fieldsetElement = userAgentElement.createChild("fieldset"); 457 fieldsetElement = userAgentElement.createChild("fieldset");
458 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("UA", WebInspector.overridesSupport.settings.userAgent, false, 0, "", undefi ned, false, false, WebInspector.UIString("No override"))); 458 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("UA", WebInspector.overridesSupport.settings.userAgent, false, 0, "", undefi ned, false, false, WebInspector.UIString("No override")));
459
460 updateNetworkCheckboxTitle();
461 WebInspector.overridesSupport.settings.networkConditionsDomains.addChang eListener(updateNetworkCheckboxTitle);
462
463 function updateNetworkCheckboxTitle()
464 {
465 var domains = WebInspector.overridesSupport.settings.networkConditio nsDomains.get();
466 if (!domains.trim()) {
467 networkCheckbox.title = WebInspector.UIString("Limit for all dom ains");
468 } else {
469 var trimmed = domains.split(",").map(function(s) { return s.trim (); }).join(", ");
470 if (trimmed.length > 40)
471 trimmed = trimmed.substring(0, 40) + "...";
472 networkCheckbox.title = WebInspector.UIString("Limit for ") + tr immed;
473 }
474 }
475 }, 459 },
476 460
477 _overridesWarningUpdated: function() 461 _overridesWarningUpdated: function()
478 { 462 {
479 var message = WebInspector.overridesSupport.warningMessage(); 463 var message = WebInspector.overridesSupport.warningMessage();
480 if (this._warningMessage.querySelector("span").textContent === message) 464 if (this._warningMessage.querySelector("span").textContent === message)
481 return; 465 return;
482 this._warningMessage.classList.toggle("hidden", !message); 466 this._warningMessage.classList.toggle("hidden", !message);
483 this._warningMessage.querySelector("span").textContent = message; 467 this._warningMessage.querySelector("span").textContent = message;
484 this._invalidateCache(); 468 this._invalidateCache();
485 this.onResize(); 469 this.onResize();
486 }, 470 },
487 471
488 _showEmulationInDrawer: function() 472 _showEmulationInDrawer: function()
489 { 473 {
490 WebInspector.overridesSupport.reveal(); 474 WebInspector.overridesSupport.reveal();
491 }, 475 },
492 476
493 __proto__: WebInspector.VBox.prototype 477 __proto__: WebInspector.VBox.prototype
494 }; 478 };
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/elements/OverridesView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698