Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 34243002: Fix mistake in r229993. (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Fix mistake in r229993. The point of that change was to run zip/extract/compile steps in the parent of src/, but it just ran them in src/ with a different spelling of it. Also do this in one more place for compile which I missed. BUG=294387 R=ilevy@google.com TBR=ilevy (who reviewed with his @google) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230044

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M build/android/buildbot/bb_host_steps.py View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 2 months ago (2013-10-22 02:55:10 UTC) #1
Isaac (use chromium)
lgtm
7 years, 2 months ago (2013-10-22 03:07:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/34243002/170001
7 years, 2 months ago (2013-10-22 03:33:06 UTC) #3
Nico
7 years, 2 months ago (2013-10-22 04:06:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r230044 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698