Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 342413005: Revert of Make SingleThreadProxy a SchedulerClient (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
CC:
cc-bugs_chromium.org, ccameron, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, joi+watch-content_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, no sievers, Mr4D (OOO till 08-26), Ian Vollick
Visibility:
Public.

Description

Revert of Make SingleThreadProxy a SchedulerClient (https://codereview.chromium.org/134623005/) Reason for revert: Check if this CL breaks TouchActionBrowserTest.TouchActionNone test http://goo.gl/pwdNwL Also it was reported that this CL causing a number of crashes on the blink bots, e.g., http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel Original issue's description: > Make SingleThreadProxy a SchedulerClient > > This makes ui::Compositor no longer in charge of > scheduling commits and draws, deferring it to cc::Scheduler. > > BUG=329552, 287250 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -594 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +8 lines, -7 lines 0 comments Download
M cc/scheduler/scheduler.cc View 9 chunks +12 lines, -15 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.h View 4 chunks +6 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 5 chunks +46 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_single_thread_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 10 chunks +47 lines, -35 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 7 chunks +8 lines, -40 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 13 chunks +140 lines, -341 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 4 chunks +25 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 5 chunks +24 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 8 chunks +107 lines, -21 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 9 chunks +17 lines, -23 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 2 chunks +3 lines, -12 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.cc View 2 chunks +12 lines, -21 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_x11.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/view_unittest.cc View 14 chunks +20 lines, -40 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Created Revert of Make SingleThreadProxy a SchedulerClient
6 years, 5 months ago (2014-06-28 17:51:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/342413005/1
6 years, 5 months ago (2014-06-28 17:52:46 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-28 17:52:47 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 17:52:48 UTC) #4
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698