Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 342413004: Re-enable all (but four) IndexedDB content browser tests on Android. (Closed)

Created:
6 years, 6 months ago by cmumford
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dgrogan, alecflett, jam, ericu+idb_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable all (but four) IndexedDB content browser tests on Android. Tested by running all IndexedDB tests (40 times) on the following devices: 1. Nexus 7: 4.4.3 2. Nexus 4: 4.2.2 3. Galaxy Nexus: 4.0.4 IndexedDBBrowserTestSingleProcess.RenderThreadShutdownTest is still disabled - just in the standard way for Android. BUG=256184, 233118 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +10 lines, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
cmumford
6 years, 6 months ago (2014-06-20 21:54:09 UTC) #1
klundberg
+Victor as he is working on content_browsertests
6 years, 6 months ago (2014-06-20 21:56:08 UTC) #2
jsbell
lgtm
6 years, 6 months ago (2014-06-20 21:58:42 UTC) #3
dgrogan
What ended up being the culprit?
6 years, 6 months ago (2014-06-20 22:45:25 UTC) #4
cmumford
On 2014/06/20 22:45:25, dgrogan wrote: > What ended up being the culprit? Don't know yet. ...
6 years, 6 months ago (2014-06-23 16:03:57 UTC) #5
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 6 months ago (2014-06-23 16:04:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/342413004/1
6 years, 6 months ago (2014-06-23 16:04:59 UTC) #7
cmumford
The CQ bit was unchecked by cmumford@chromium.org
6 years, 6 months ago (2014-06-23 17:41:42 UTC) #8
cmumford
On 2014/06/23 17:41:42, cmumford wrote: > The CQ bit was unchecked by mailto:cmumford@chromium.org I didn't ...
6 years, 6 months ago (2014-06-23 17:43:25 UTC) #9
jsbell
What's the plan here? Still waiting for reviews?
6 years, 5 months ago (2014-07-10 19:47:47 UTC) #10
cmumford
On 2014/07/10 19:47:47, jsbell wrote: > What's the plan here? Still waiting for reviews? Yes ...
6 years, 5 months ago (2014-07-14 17:12:56 UTC) #11
Victor Starodub
lgtm But we had quite a few race conditions w/content_browsertests, so these might turn out ...
6 years, 5 months ago (2014-07-14 18:33:20 UTC) #12
cmumford
On 2014/07/14 18:33:20, Victor Starodub wrote: > lgtm > > But we had quite a ...
6 years, 5 months ago (2014-07-14 18:40:13 UTC) #13
Victor Starodub
I don't think there's much we can test separately here apart from running on trybots. ...
6 years, 5 months ago (2014-07-14 18:55:46 UTC) #14
cmumford
Ping for other reviewers.
6 years, 5 months ago (2014-07-17 18:20:38 UTC) #15
frankf
6 years, 5 months ago (2014-07-17 18:27:10 UTC) #16
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 4 months ago (2014-07-31 20:59:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/342413004/1
6 years, 4 months ago (2014-07-31 21:02:45 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 17:18:30 UTC) #19
Message was sent while issue was closed.
Change committed as 287030

Powered by Google App Engine
This is Rietveld 408576698