Use IDL argument default values in Document.idl

Use IDL argument default values in Document.idl

The 'whatToShow' and 'filter' arguments to the createNodeIterator() and
createTreeWalker() methods have default values in the specification.
Add those default values in Document.idl, and get rid of the extra
overloads of Document::createNodeIterator() and ::createTreeWalker().

BUG=258153
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176938

[Jens Widell, 2014-06-25 15:37:01]

PTAL

Note: importNode() should also have a default (deep=false), but we have the
wrong default currently, and a UseCounter + deprecation message on it being
called without the argument, so leaving it alone for one. When we go through
with that behavioral change, we should do it by adding a default value in the
IDL.

[haraken, 2014-06-25 15:40:57]

LGTM

https://codereview.chromium.org/342403007/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (left):

https://codereview.chromium.org/342403007/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:1547: // FIXME: Probably this should be handled
within the bindings layer and TypeError should be thrown.

Shall we leave this FIXME (and address it in a follow-up if you're willing to
fix it)?

[Jens Widell, 2014-06-25 15:52:48]

https://codereview.chromium.org/342403007/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (left):

https://codereview.chromium.org/342403007/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:1547: // FIXME: Probably this should be handled
within the bindings layer and TypeError should be thrown.
Yes, we certainly should leave the FIXME. Sorry about that.

And I'll look into addressing it in a follow-up as well.

[Jens Widell, 2014-06-25 15:53:20]

The CQ bit was checked by jl@opera.com

[Jens Widell, 2014-06-25 15:53:24]

The CQ bit was unchecked by jl@opera.com

[Jens Widell, 2014-06-25 15:55:18]

On 2014/06/25 15:53:24, Jens Lindström wrote:
> The CQ bit was unchecked by mailto:jl@opera.com

I'll commit this once https://codereview.chromium.org/340783012/ has landed.

[Jens Widell, 2014-06-25 16:39:31]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-06-25 16:40:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/342403007/20001

[commit-bot: I haz the power, 2014-06-25 17:45:59]

Change committed as 176938