Issue 342353003: Don't use DirectWrite if smoothing or ClearType is off

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342353003: Don't use DirectWrite if smoothing or ClearType is off (Closed)

Created:
6 years, 5 months ago by scottmg

Modified:
6 years, 4 months ago

Reviewers:
cpu_(ooo_6.6-7.5), sky, eae

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't use DirectWrite if smoothing or ClearType is off I'm not honestly sure if this is right, everything looks kind of crappy when I start turning these things off. But I think this is better? This should make us fallback to GDI rendering. I'm not certain if this will turn off subpixel positition in blink though. (we don't turn it _on_, at least) R=cpu@chromium.org,sky@chromium.org,eae@chromium.org BUG=383372

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	content/common/sandbox_win.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eae

On 2014/06/28 01:10:27, eae wrote: > non-owner lgtm Please hold off committing this for a ...

6 years, 5 months ago (2014-06-30 00:32:28 UTC) #4

eae

6 years, 5 months ago (2014-06-30 17:14:20 UTC) #5

On 2014/06/30 00:32:28, eae wrote:
> On 2014/06/28 01:10:27, eae wrote:
> > non-owner lgtm
> 
> Please hold off committing this for a little while, I want to see if we can
> still use DirectWrite but disable subpixel positioning instead.

Disabling subpixel positioning fixes this without having to disable DW. Seems
like the better option.

NOT LGTM

Expand Messages | Collapse Messages