Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 342333002: Array.concat: properly go to dictionary mode when required (Closed)

Created:
6 years, 6 months ago by Jakob Kummerow
Modified:
6 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Array.concat: properly go to dictionary mode when required BUG=chromium:387031 LOG=y R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M src/runtime.cc View 3 chunks +10 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-387031.js View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
6 years, 6 months ago (2014-06-20 15:11:17 UTC) #1
danno
lgtm
6 years, 6 months ago (2014-06-20 15:22:37 UTC) #2
Jakob Kummerow
6 years, 6 months ago (2014-06-20 15:40:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698