Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 342303002: Open-source the remaining PLT-related histogram definitions. (Closed)

Created:
6 years, 6 months ago by ppi
Modified:
6 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Open-source the remaining PLT-related histogram definitions. This patch moves the remaining (mostly legacy) definitions of PLT.* histograms and related enums to the chromium repository. BUG=384330, 223859 R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279095

Patch Set 1 : #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+796 lines, -24 lines) Patch
M tools/metrics/histograms/histograms.xml View 26 chunks +796 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ppi
ptal.
6 years, 6 months ago (2014-06-20 11:08:31 UTC) #1
Alexei Svitkine (slow)
LGTM, assuming this is a purely mechanical move. Thanks!
6 years, 6 months ago (2014-06-20 14:59:30 UTC) #2
ppi
Thanks!
6 years, 6 months ago (2014-06-20 23:51:57 UTC) #3
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 6 months ago (2014-06-20 23:52:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/342303002/20001
6 years, 6 months ago (2014-06-20 23:53:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-21 02:22:44 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 02:24:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/24042)
6 years, 6 months ago (2014-06-21 02:24:47 UTC) #8
ppi
6 years, 6 months ago (2014-06-23 12:26:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r279095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698