Source/core/html/HTMLFormElement.cpp - Issue 342283005: Make collection caching code more consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 342283005: Make collection caching code more consistent (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Stop including NodeListsNodeData.h in ContainerNode.h Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFormElement.cpp

diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp

index 985b37cff00ef4c8949a3ade7c54d9a1fecdeca4..d2c14006352e2c6632479631ed0f93e170349b40 100644

--- a/Source/core/html/HTMLFormElement.cpp

+++ b/Source/core/html/HTMLFormElement.cpp

@@ -33,6 +33,7 @@

#include "core/dom/Document.h"

#include "core/dom/ElementTraversal.h"

#include "core/dom/IdTargetObserverRegistry.h"

+#include "core/dom/NodeListsNodeData.h"

#include "core/events/AutocompleteErrorEvent.h"

#include "core/events/Event.h"

#include "core/events/GenericEventQueue.h"

@@ -589,7 +590,7 @@ void HTMLFormElement::didAssociateByParser()

PassRefPtrWillBeRawPtr<HTMLFormControlsCollection> HTMLFormElement::elements()

{

- return toHTMLFormControlsCollection(ensureCachedHTMLCollection(FormControls).get());

+ return ensureCachedCollection<HTMLFormControlsCollection>(FormControls);

}

void HTMLFormElement::collectAssociatedElements(Node& root, FormAssociatedElement::List& elements) const