Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: Source/core/dom/Element.cpp

Issue 342283005: Make collection caching code more consistent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Stop including NodeListsNodeData.h in ContainerNode.h Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index f7f3bf246f50a5e5fea9f46822a0c17bea0c7030..6e494e5acb32b8e293d7479014b82f9bfe3861a0 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -2945,34 +2945,11 @@ void Element::updateExtraNamedItemRegistration(const AtomicString& oldId, const
toHTMLDocument(document()).addExtraNamedItem(newId);
}
-PassRefPtrWillBeRawPtr<HTMLCollection> Element::ensureCachedHTMLCollection(CollectionType type)
-{
- if (HTMLCollection* collection = cachedHTMLCollection(type))
- return collection;
-
- if (type == TableRows) {
- ASSERT(isHTMLTableElement(this));
- return ensureRareData().ensureNodeLists().addCache<HTMLTableRowsCollection>(*this, type);
- } else if (type == SelectOptions) {
- ASSERT(isHTMLSelectElement(this));
- return ensureRareData().ensureNodeLists().addCache<HTMLOptionsCollection>(*this, type);
- } else if (type == FormControls) {
- ASSERT(isHTMLFormElement(this) || isHTMLFieldSetElement(this));
- return ensureRareData().ensureNodeLists().addCache<HTMLFormControlsCollection>(*this, type);
- }
- return ensureRareData().ensureNodeLists().addCache<HTMLCollection>(*this, type);
-}
-
void Element::scheduleSVGFilterLayerUpdateHack()
{
document().scheduleSVGFilterLayerUpdateHack(*this);
}
-HTMLCollection* Element::cachedHTMLCollection(CollectionType type)
-{
- return hasRareData() && rareData()->nodeLists() ? rareData()->nodeLists()->cached<HTMLCollection>(type) : 0;
-}
-
IntSize Element::savedLayerScrollOffset() const
{
return hasRareData() ? elementRareData()->savedLayerScrollOffset() : IntSize();

Powered by Google App Engine
This is Rietveld 408576698