[DataTransfer] setDragImage() y offset is ignored

[DataTransfer] setDragImage() y offset is ignored

The y offset is forcefully cleared to make the cursor appear at the top
of the drag image. This causes the y offset set by user via the setDragImage()
to be ignored by Chrome.

BUG=380105
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278956

[spartha, 2014-06-20 11:19:00]

PTAL. If this change is ok, is there any testing infra avaiable to test this
case? I have not written any browser tests yet. Thanks!

https://codereview.chromium.org/342283003/diff/1/ui/views/widget/desktop_aura...
File ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc (left):

https://codereview.chromium.org/342283003/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc:283: // Reset the Y
offset, so that the drag-image is always just below the cursor,
This looks like more of a UX descision. But this causes the
dataTransfer.setDragImage to ignore the y offset. Is this delibrate?

[Elliot Glaysher, 2014-06-20 17:55:15]

+sadrul, who wrote that originally?

[sadrul, 2014-06-20 18:12:06]

On 2014/06/20 11:19:00, spartha wrote:
> PTAL. If this change is ok, is there any testing infra avaiable to test this
> case? I have not written any browser tests yet. Thanks!
> 
>
https://codereview.chromium.org/342283003/diff/1/ui/views/widget/desktop_aura...
> File ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc (left):
> 
>
https://codereview.chromium.org/342283003/diff/1/ui/views/widget/desktop_aura...
> ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc:283: // Reset the Y
> offset, so that the drag-image is always just below the cursor,
> This looks like more of a UX descision. But this causes the
> dataTransfer.setDragImage to ignore the y offset. Is this delibrate?

It was deliberate at the time I wrote the CL, yeah. But sounds like we don't do
this on Windows, so it makes sense to remove this code and match the behaviour
on Windows.

LGTM

[spartha, 2014-06-20 20:52:58]

The CQ bit was checked by sudarshan.p@samsung.com

[commit-bot: I haz the power, 2014-06-20 20:55:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/342283003/1

[commit-bot: I haz the power, 2014-06-21 07:55:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-21 13:18:09]

Change committed as 278956