Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 342283003: [DataTransfer] setDragImage() y offset is ignored (Closed)

Created:
6 years, 6 months ago by spartha
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DataTransfer] setDragImage() y offset is ignored The y offset is forcefully cleared to make the cursor appear at the top of the drag image. This causes the y offset set by user via the setDragImage() to be ignored by Chrome. BUG=380105 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278956

Patch Set 1 : WIP Patch #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
spartha
PTAL. If this change is ok, is there any testing infra avaiable to test this ...
6 years, 6 months ago (2014-06-20 11:19:00 UTC) #1
Elliot Glaysher
+sadrul, who wrote that originally?
6 years, 6 months ago (2014-06-20 17:55:15 UTC) #2
sadrul
On 2014/06/20 11:19:00, spartha wrote: > PTAL. If this change is ok, is there any ...
6 years, 6 months ago (2014-06-20 18:12:06 UTC) #3
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 6 months ago (2014-06-20 20:52:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/342283003/1
6 years, 6 months ago (2014-06-20 20:55:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-21 07:55:41 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 13:18:09 UTC) #7
Message was sent while issue was closed.
Change committed as 278956

Powered by Google App Engine
This is Rietveld 408576698