chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc - Issue 342233005: Move ownership of the ComponentCloudPolicyService to the broker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc

Issue 342233005: Move ownership of the ComponentCloudPolicyService to the broker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_local_account_policy_service.cc ('k') | chrome/browser/policy/schema_registry_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc b/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc

index 0f9160a7a19fda837efa627b41a451bd57904330..c77f9c1771784fb9de93c8ec8d1d460645a8675b 100644

--- a/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc

@@ -405,7 +405,9 @@ TEST_F(DeviceLocalAccountPolicyServiceTest, FetchPolicy) {

device_policy_.policy_data().device_id(),

_))

.WillOnce(SaveArg<6>(&request));

- EXPECT_CALL(service_observer_, OnPolicyUpdated(account_1_user_id_));

+ // This will be called twice, because the ComponentCloudPolicyService will

+ // also become ready after flushing all the pending tasks.

+ EXPECT_CALL(service_observer_, OnPolicyUpdated(account_1_user_id_)).Times(2);

broker->core()->client()->FetchPolicy();

FlushDeviceSettings();

Mock::VerifyAndClearExpectations(&service_observer_);

@@ -449,7 +451,9 @@ TEST_F(DeviceLocalAccountPolicyServiceTest, RefreshPolicy) {

.WillOnce(mock_device_management_service_.SucceedJob(response));

EXPECT_CALL(mock_device_management_service_, StartJob(_, _, _, _, _, _, _));

EXPECT_CALL(*this, OnRefreshDone(true)).Times(1);

- EXPECT_CALL(service_observer_, OnPolicyUpdated(account_1_user_id_));

+ // This will be called twice, because the ComponentCloudPolicyService will

+ // also become ready after flushing all the pending tasks.

+ EXPECT_CALL(service_observer_, OnPolicyUpdated(account_1_user_id_)).Times(2);

broker->core()->service()->RefreshPolicy(

base::Bind(&DeviceLocalAccountPolicyServiceTest::OnRefreshDone,

base::Unretained(this)));