Source/web/tests/data/viewport/viewport-warnings-8.html - Issue 342163003: Uptake http://trac.webkit.org/changeset/169848

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/viewport/viewport-warnings-8.html

Issue 342163003: Uptake http://trac.webkit.org/changeset/169848 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed test case Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <head>

	2 <title>Invalid value should be truncated: 130 followed by latin capital lett er i with dot above (U+0130)</title>

	3 <meta name="viewport" content="width=123İ">
	arv (Not doing code reviews) 2014/06/20 14:31:37 This test is suffering from the same issue as the This test is suffering from the same issue as the invalid test in http://trac.webkit.org/changeset/169849 Since the length got longer it just means we stopped checking the string before we processed the whole thing. To really test that the code works we need to put U+0130 at the beginning. I'm not fully sure what the syntax is for meta viewport but something like this might be a better test: <meta name="viewport" content="İİ=ignore,width=123"> and then assert that we treated width as "123" and not as "1", which it would with the old code since the old code would end iterating 2 characters too early.
	4 </head>

OLD	NEW