Issue 342163002: DevTools: move emulation button into the base App.js.

Issue 342163002: DevTools: move emulation button into the base App.js. (Closed)

Created:
6 years, 6 months ago by pfeldman

Modified:
6 years, 6 months ago

Reviewers:
dgozman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: move emulation button into the base App.js. R=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176515

Patch Set 1 #

Patch Set 2 : Rebaselined #

Total comments: 8

Patch Set 3 : Review comments addressed. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -113 lines)			Patch
M	LayoutTests/inspector/device-emulation/device-emulation-test.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/ResponsiveDesignView.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/elements/OverridesView.js	View	1	3 chunks	+8 lines, -10 lines	0 comments	Download
M	Source/devtools/front_end/inspector.css	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/main/AdvancedApp.js	View		2 chunks	+0 lines, -37 lines	0 comments	Download
M	Source/devtools/front_end/main/App.js	View	1 2	2 chunks	+39 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/main/module.json	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/overrides.css	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/OverridesSupport.js	View	1 2	17 chunks	+47 lines, -59 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgozman

lgtm https://codereview.chromium.org/342163002/diff/20001/Source/devtools/front_end/main/App.js File Source/devtools/front_end/main/App.js (right): https://codereview.chromium.org/342163002/diff/20001/Source/devtools/front_end/main/App.js#newcode49 Source/devtools/front_end/main/App.js:49: WebInspector.App.ResponsiveDesignButtonProvider = function() EmulationButtonProvider https://codereview.chromium.org/342163002/diff/20001/Source/devtools/front_end/main/App.js#newcode61 Source/devtools/front_end/main/App.js:61: return /** ...

6 years, 6 months ago (2014-06-19 14:42:32 UTC) #2

pfeldman

https://codereview.chromium.org/342163002/diff/20001/Source/devtools/front_end/main/App.js File Source/devtools/front_end/main/App.js (right): https://codereview.chromium.org/342163002/diff/20001/Source/devtools/front_end/main/App.js#newcode49 Source/devtools/front_end/main/App.js:49: WebInspector.App.ResponsiveDesignButtonProvider = function() Done! https://codereview.chromium.org/342163002/diff/20001/Source/devtools/front_end/main/App.js#newcode61 Source/devtools/front_end/main/App.js:61: return /** @type ...

6 years, 6 months ago (2014-06-19 14:51:25 UTC) #3

pfeldman

6 years, 6 months ago (2014-06-19 14:53:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r176515 (presubmit successful).

Expand Messages | Collapse Messages