Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 342153002: LeakExpectations: mark svg fonts leaks as false-positives (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, oilpan-reviews
Project:
blink
Visibility:
Public.

Description

LeakExpectations: mark svg fonts leaks as false-positives HarfBuzzRunCache is a global cache with entries holding |Font| which indirectly hold strong ref to |SVGFontFace|. In future, the leak detector should clear the cache before counting number of |Document|s. These "leaks" disappear if following line is commented out: WebKit/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp 861 runCache.insert(key, new CachedShapingResults(harfBuzzBuffer.get(), m_font, props.direction, localeString)); BUG=366455 TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176490

Patch Set 1 #

Patch Set 2 : make LeakExpectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M LayoutTests/LeakExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kouhei (in TOK)
6 years, 6 months ago (2014-06-19 05:11:05 UTC) #1
kouhei (in TOK)
+haraken
6 years, 6 months ago (2014-06-19 05:11:25 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-19 05:15:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/342153002/20001
6 years, 6 months ago (2014-06-19 05:16:26 UTC) #4
commit-bot: I haz the power
Change committed as 176490
6 years, 6 months ago (2014-06-19 05:16:49 UTC) #5
haraken
6 years, 6 months ago (2014-06-19 05:21:33 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698