content/common/view_messages.h - Issue 342143004: Defect 248426: Speak rendered text when no selection is made on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 342143004: Defect 248426: Speak rendered text when no selection is made on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a link to newly created defect that addresses IPC data handling capabilities Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/renderer/render_view_browsertest_mac.mm » ('j') | content/renderer/render_view_browsertest_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 144430ad4ca7bd3ca4dd61a337b5d324ab872433..b55de6e49b60a22c57c32811136d63aa9f9f252f 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -884,6 +884,10 @@ IPC_MESSAGE_ROUTED3(ViewMsg_WindowSnapshotCompleted,

gfx::Size /* size */,

std::vector<unsigned char> /* png */)

+// Sends an Async IPC request to webview for complete content of a

jamesr 2014/07/18 06:05:04 nit: the fact that this is an async IPC and that i

sarka 2014/07/19 06:28:36 Done.

+// web page as plain text.

+IPC_MESSAGE_ROUTED0(ViewMsg_GetRenderedText)

#if defined(OS_MACOSX)

IPC_ENUM_TRAITS_MAX_VALUE(blink::ScrollerStyle, blink::ScrollerStyleOverlay)

@@ -1671,6 +1675,9 @@ IPC_MESSAGE_ROUTED2(ViewHostMsg_PluginFocusChanged,

// Instructs the browser to start plugin IME.

IPC_MESSAGE_ROUTED0(ViewHostMsg_StartPluginIme)

+// Receives content of a web page as plain text.

+IPC_MESSAGE_ROUTED1(ViewMsg_GetRenderedTextCompleted, std::string);

#elif defined(OS_WIN)

// Request that the given font characters be loaded by the browser so it's

// cached by the OS. Please see RenderMessageFilter::OnPreCacheFontCharacters