Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 342143004: Defect 248426: Speak rendered text when no selection is made on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Style changes fixed for Defect 248426 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 10384c218ec1a137b80f44b9d037677896f47a64..e19b656501ebe9aee2c1f319a9b93f4f2c1523dd 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -488,6 +488,7 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget)
// |GetNativeView()| into the view hierarchy right after calling us.
cocoa_view_ = [[[RenderWidgetHostViewCocoa alloc]
initWithRenderWidgetHostViewMac:this] autorelease];
+
Alexei Svitkine (slow) 2014/06/27 15:54:30 Hmm, I don't understand why the diff looks so. I c
sarka 2014/06/27 16:26:14 This is really strange. I had to throw in an extra
background_layer_.reset([[CALayer alloc] init]);
[background_layer_
setBackgroundColor:CGColorGetConstantColor(kCGColorWhite)];
@@ -1088,7 +1089,7 @@ void RenderWidgetHostViewMac::SpeakSelection() {
// Route an IPC message to get content as text for a web contents.
render_widget_host_->Send(new ViewMsg_GetRenderedText(
render_widget_host_->GetRoutingID()));
- return;
+ return;
}
[NSApp speakString:base::SysUTF8ToNSString(selected_text_)];
@@ -2340,6 +2341,7 @@ void RenderWidgetHostViewMac::AcceleratedLayerDidDrawFrame(bool succeeded) {
focusedPluginIdentifier_ = -1;
renderWidgetHostView_->backing_store_scale_factor_ =
ui::GetScaleFactorForNativeView(self);
+
// OpenGL support:
if ([self respondsToSelector:
@selector(setWantsBestResolutionOpenGLSurface:)]) {

Powered by Google App Engine
This is Rietveld 408576698