Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: Source/core/frame/UseCounter.h

Issue 342103003: Support UseCounter in dedicated workers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Support countDeprecation Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index 8d0abe4a6564e2beb0a70bb82bb8cdeffddac986..dbd497321421b06daa88fef7c19e8f2e6623463e 100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -278,7 +278,7 @@ public:
HTMLMediaElementSeekToFragmentStart = 281,
HTMLMediaElementPauseAtFragmentEnd = 282,
PrefixedWindowURL = 283,
- PrefixedWorkerURL = 284,
+ PrefixedWorkerURL = 284, // This didn't work because of crbug.com/376039. Available since M37.
WindowOrientation = 285,
DOMStringListContains = 286,
DocumentCaptureEvents = 287,
@@ -307,8 +307,8 @@ public:
NamedNodeMapGetNamedItemNS = 310,
NamedNodeMapSetNamedItemNS = 311,
NamedNodeMapRemoveNamedItemNS = 312,
- OpenWebDatabaseInWorker = 313, // This doesn't work because of crbug.com/376039.
- OpenWebDatabaseSyncInWorker = 314, // This doesn't work because of crbug.com/376039.
+ OpenWebDatabaseInWorker = 313, // This didn't work because of crbug.com/376039. Available since M37.
+ OpenWebDatabaseSyncInWorker = 314, // This didn't work because of crbug.com/376039. Available since M37.
PrefixedAllowFullscreenAttribute = 315,
XHRProgressEventPosition = 316,
XHRProgressEventTotalSize = 317,
@@ -478,7 +478,8 @@ public:
// "count" sets the bit for this feature to 1. Repeated calls are ignored.
static void count(const Document&, Feature);
- // This doesn't count for non-Document ExecutionContext.
+ // This doesn't count for ExecutionContexts for shared workers and service
+ // workers.
static void count(const ExecutionContext*, Feature);
void count(CSSParserContext, CSSPropertyID);
void count(Feature);
@@ -486,8 +487,12 @@ public:
// "countDeprecation" sets the bit for this feature to 1, and sends a deprecation
// warning to the console. Repeated calls are ignored.
//
- // Be considerate to developers' consoles: features should only send deprecation warnings
- // when we're actively interested in removing them from the platform.
+ // Be considerate to developers' consoles: features should only send
+ // deprecation warnings when we're actively interested in removing them from
+ // the platform.
+ //
+ // The ExecutionContext* overload doesn't work for shared workers and
+ // service workers.
static void countDeprecation(const DOMWindow*, Feature);
static void countDeprecation(ExecutionContext*, Feature);
static void countDeprecation(const Document&, Feature);
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698