Support UseCounter in dedicated workers.

Support UseCounter in dedicated workers.

BUG=376039
R=haraken@chromium.org, sigbjornf@opera.com, tyoshino@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176511

[tkent, 2014-06-19 05:10:02]

Please review this.

I confirmed MeasureAs= in
Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.idl worked well.

[haraken, 2014-06-19 05:29:01]

LGTM, but sof@ might want to take another look.

https://codereview.chromium.org/342103003/diff/1/Source/core/workers/Dedicate...
File Source/core/workers/DedicatedWorkerGlobalScope.cpp (right):

https://codereview.chromium.org/342103003/diff/1/Source/core/workers/Dedicate...
Source/core/workers/DedicatedWorkerGlobalScope.cpp:86: class CounterTask :
public ExecutionContextTask {

CounterTask => UseCounterTask ?

https://codereview.chromium.org/342103003/diff/1/Source/core/workers/Dedicate...
Source/core/workers/DedicatedWorkerGlobalScope.cpp:91:
CounterTask(UseCounter::Feature feature) : m_feature(feature) { }

Add explicit.

[tkent, 2014-06-19 05:34:09]

https://codereview.chromium.org/342103003/diff/1/Source/core/workers/Dedicate...
File Source/core/workers/DedicatedWorkerGlobalScope.cpp (right):

https://codereview.chromium.org/342103003/diff/1/Source/core/workers/Dedicate...
Source/core/workers/DedicatedWorkerGlobalScope.cpp:86: class CounterTask :
public ExecutionContextTask {
On 2014/06/19 05:29:01, haraken wrote:
> 
> CounterTask => UseCounterTask ?

Done.

https://codereview.chromium.org/342103003/diff/1/Source/core/workers/Dedicate...
Source/core/workers/DedicatedWorkerGlobalScope.cpp:91:
CounterTask(UseCounter::Feature feature) : m_feature(feature) { }
On 2014/06/19 05:29:01, haraken wrote:
> 
> Add explicit.

Done.

[sof, 2014-06-19 06:26:04]

s/decicated/dedicated/ in CL title (and description.)

https://codereview.chromium.org/342103003/diff/20001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/342103003/diff/20001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.cpp:622: if (!context || !context->isDocument())
What about deprecated counts and workers?

[tkent, 2014-06-19 06:58:44]

> s/decicated/dedicated/ in CL title (and description.)

Done.

https://codereview.chromium.org/342103003/diff/20001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/342103003/diff/20001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.cpp:622: if (!context || !context->isDocument())
On 2014/06/19 06:26:04, sof wrote:
> What about deprecated counts and workers?

Good catch!  Done.

[sof, 2014-06-19 07:08:50]

lgtm; not having to keep a separate per-Worker UseCounter bitset is preferable
and simpler.

(Need to figure out something for the shared worker case though.)

[tkent, 2014-06-19 07:13:45]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-19 07:14:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/342103003/40001

[tyoshino (SeeGerritForStatus), 2014-06-19 08:06:25]

Chatted with tkent@ offline. FTR, there're some paths we can postTask() to some
Document instance (e.g. WorkerLoaderProxy) even for ServiceWorker, SharedWorker
cases. But we're not sure if incrementing counter for such random pages makes
sense. We should rather add some counter system to count usage for each Worker
instance not the associated page.

lgtm

[sof, 2014-06-19 09:01:33]

Just a suggestion, a PSA to blink-dev might possibly be worth doing once this
has landed? It doesn't affect too many counters, but good to know that dedicated
worker use will now be accounted for.

[commit-bot: I haz the power, 2014-06-19 10:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 10:29:38]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[tkent, 2014-06-19 10:45:23]

On 2014/06/19 09:01:33, sof wrote:
> Just a suggestion, a PSA to blink-dev might possibly be worth doing once this
> has landed? It doesn't affect too many counters, but good to know that
dedicated
> worker use will now be accounted for.

Indeed.  I'll announce it.

[tkent, 2014-06-19 10:45:27]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-19 10:46:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/342103003/40001

[commit-bot: I haz the power, 2014-06-19 12:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 12:28:54]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[tkent, 2014-06-19 12:45:18]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-19 12:46:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/342103003/40001

[tkent, 2014-06-19 13:45:14]

Committed patchset #3 manually as r176511 (presubmit successful).