Issue 3421029: Fix a c_str() use-after-free bug in the chrome frame code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3421029: Fix a c_str() use-after-free bug in the chrome frame code. (Closed)

Created:
10 years, 3 months ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Visibility:
Public.

Description

Fix a c_str() use-after-free bug in the chrome frame code. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60233

Patch Set 1 #

Total comments: 1

Patch Set 2 : Eliminate temporary #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome_frame/chrome_active_document.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

Hi Amit, Please review. I happened across this when searching the code.

10 years, 3 months ago (2010-09-22 21:24:09 UTC) #1

amit

10 years, 3 months ago (2010-09-22 21:39:23 UTC) #2

LGTM! Thanks for spotting this.

http://codereview.chromium.org/3421029/diff/1/2
File chrome_frame/chrome_active_document.cc (right):

http://codereview.chromium.org/3421029/diff/1/2#newcode935
chrome_frame/chrome_active_document.cc:935: LPCWSTR popup_wnd_url =
url_wide.c_str();
nit: I think we can get rid of a temporary or two.

Expand Messages | Collapse Messages