MSE: Give decode error if MDAT discard peek fails

media/formats/mp4/mp4_stream_parser.cc

Index: media/formats/mp4/mp4_stream_parser.cc
diff --git a/media/formats/mp4/mp4_stream_parser.cc b/media/formats/mp4/mp4_stream_parser.cc
index ceefcfa963a0b5840593f13ae52531fde824f6a2..4be859782292e77d6305516d1ca741d969227f8a 100644
--- a/media/formats/mp4/mp4_stream_parser.cc
+++ b/media/formats/mp4/mp4_stream_parser.cc
@@ -553,6 +553,8 @@ bool MP4StreamParser::ReadAndDiscardMDATsUntil(const int64 offset) {
     const uint8* buf;
     int size;
     queue_.PeekAt(mdat_tail_, &buf, &size);

[DaleCurtis, 2014/06/19 00:58:20]

drive-by:  the above vars should be zero-initialized since this method doesn't
return a value.

[wolenetz, 2014/06/19 01:21:31]

Good point. Done.

+    if (!buf)

[acolwell GONE FROM CHROMIUM, 2014/06/19 00:57:03]

nit: s/!buf/size == 0/ since all the other PeekAt() callers check size?

[wolenetz, 2014/06/19 01:21:31]

Done (size <= 0)

+      return false;
 
     FourCC type;
     int box_sz;