MSE: Give decode error if MDAT discard peek fails

MSE: Give decode error if MDAT discard peek fails

Explicitly issue decode error if MP4 stream parser peek fails during
MDAT discarding.

BUG=380806
R=acolwell@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278344

[wolenetz, 2014-06-19 00:51:31]

PTAL @ PS1. Thanks!

[acolwell GONE FROM CHROMIUM, 2014-06-19 00:57:03]

lgtm

https://codereview.chromium.org/342083002/diff/1/media/formats/mp4/mp4_stream...
File media/formats/mp4/mp4_stream_parser.cc (right):

https://codereview.chromium.org/342083002/diff/1/media/formats/mp4/mp4_stream...
media/formats/mp4/mp4_stream_parser.cc:556: if (!buf)
nit: s/!buf/size == 0/ since all the other PeekAt() callers check size?

[DaleCurtis, 2014-06-19 00:58:20]

https://codereview.chromium.org/342083002/diff/1/media/formats/mp4/mp4_stream...
File media/formats/mp4/mp4_stream_parser.cc (right):

https://codereview.chromium.org/342083002/diff/1/media/formats/mp4/mp4_stream...
media/formats/mp4/mp4_stream_parser.cc:555: queue_.PeekAt(mdat_tail_, &buf,
&size);
drive-by:  the above vars should be zero-initialized since this method doesn't
return a value.

[wolenetz, 2014-06-19 01:21:31]

PTAL @ PS2 (drive-by + I used <= 0, not == 0). Thanks!

https://codereview.chromium.org/342083002/diff/1/media/formats/mp4/mp4_stream...
File media/formats/mp4/mp4_stream_parser.cc (right):

https://codereview.chromium.org/342083002/diff/1/media/formats/mp4/mp4_stream...
media/formats/mp4/mp4_stream_parser.cc:555: queue_.PeekAt(mdat_tail_, &buf,
&size);
On 2014/06/19 00:58:20, DaleCurtis wrote:
> drive-by:  the above vars should be zero-initialized since this method doesn't
> return a value.

Good point. Done.

https://codereview.chromium.org/342083002/diff/1/media/formats/mp4/mp4_stream...
media/formats/mp4/mp4_stream_parser.cc:556: if (!buf)
On 2014/06/19 00:57:03, acolwell wrote:
> nit: s/!buf/size == 0/ since all the other PeekAt() callers check size?

Done (size <= 0)

[wolenetz, 2014-06-19 01:52:41]

I received offline lgtm2 from acolwell

[wolenetz, 2014-06-19 01:52:45]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2014-06-19 01:53:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wolenetz@chromium.org/342083002/20001

[commit-bot: I haz the power, 2014-06-19 12:38:29]

Change committed as 278344