chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 342068: Third patch in getting rid of caching MessageLoop pointers and always using C...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 342068: Third patch in getting rid of caching MessageLoop pointers and always using C... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/resource_message_filter_mac.mm ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

===================================================================

--- chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (revision 30650)

+++ chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (working copy)

@@ -11,7 +11,7 @@

#include "base/histogram.h"

#include "base/string_util.h"

#include "base/values.h"

-#include "chrome/browser/browser_process.h"

+#include "chrome/browser/chrome_thread.h"

#include "chrome/browser/dom_operation_notification_details.h"

#include "chrome/browser/dom_ui/new_tab_ui.h"

#include "chrome/browser/google_util.h"

@@ -437,15 +437,11 @@

SafeBrowsingService* sb_service,

const UnsafeResourceList& unsafe_resources,

bool proceed) {

- MessageLoop* message_loop;

- if (g_browser_process->io_thread())

- message_loop = g_browser_process->io_thread()->message_loop();

- else // For unit-tests, just post on the current thread.

- message_loop = MessageLoop::current();

- message_loop->PostTask(FROM_HERE, NewRunnableMethod(

- sb_service, &SafeBrowsingService::OnBlockingPageDone, unsafe_resources,

- proceed));

+ ChromeThread::PostTask(

+ ChromeThread::IO, FROM_HERE,

+ NewRunnableMethod(

+ sb_service, &SafeBrowsingService::OnBlockingPageDone,

+ unsafe_resources, proceed));

}

// static