Third patch in getting rid of caching MessageLoop pointers and always using C...

chrome/browser/spellcheck_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webkit_glue.h"
 
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/sys_string_conversions.h"
+#include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/spellchecker.h"
 #include "chrome/browser/spellchecker_platform_engine.h"
 #include "chrome/common/chrome_paths.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 const FilePath::CharType kTempCustomDictionaryFile[] =
     FILE_PATH_LITERAL("temp_custom_dictionary.txt");
 }  // namespace
 
 class SpellCheckTest : public testing::Test {
+ public:
+  SpellCheckTest()
+      : file_thread_(ChromeThread::FILE, &message_loop_),
+        io_thread_(ChromeThread::IO, &message_loop_) {}
+
+ protected:
+  MessageLoop message_loop_;
+
  private:
-  MessageLoop message_loop_;
+  ChromeThread file_thread_;
+  ChromeThread io_thread_;  // To keep DCHECKs inside spell checker happy.
 };
 
 // Represents a special initialization function used only for the unit tests
 // in this file.
 extern void InitHunspellWithFiles(FILE* file_aff_hunspell,
                                   FILE* file_dic_hunspell);
 
 FilePath GetHunspellDirectory() {
   FilePath hunspell_directory;
   if (!PathService::Get(base::DIR_SOURCE_ROOT, &hunspell_directory))
@@ skipping 230 matching lines @@
     // spellcheck" <http://crbug.com/13432>.
     {L"qwertyuiopasd", false, 0, 13},
     {L"qwertyuiopasdf", false, 0, 14},
   };
 
   FilePath hunspell_directory = GetHunspellDirectory();
   ASSERT_FALSE(hunspell_directory.empty());
 
   scoped_refptr<SpellChecker> spell_checker(new SpellChecker(
       hunspell_directory, "en-US", NULL, FilePath()));
+  spell_checker->Initialize();
+  message_loop_.RunAllPending();
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     size_t input_length = 0;
     if (kTestCases[i].input != NULL) {
       input_length = wcslen(kTestCases[i].input);
     }
     int misspelling_start;
     int misspelling_length;
     bool result = spell_checker->SpellCheckWord(
         WideToUTF16(kTestCases[i].input).c_str(),
@@ skipping 325 matching lines @@
     {L"jum", false, 0, 0, L"um"},
 #endif  // !OS_MACOSX
     // TODO (Sidchat): add many more examples.
   };
 
   FilePath hunspell_directory = GetHunspellDirectory();
   ASSERT_FALSE(hunspell_directory.empty());
 
   scoped_refptr<SpellChecker> spell_checker(new SpellChecker(
       hunspell_directory, "en-US", NULL, FilePath()));
+  spell_checker->Initialize();
+  message_loop_.RunAllPending();
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     std::vector<string16> suggestions;
     size_t input_length = 0;
     if (kTestCases[i].input != NULL) {
       input_length = wcslen(kTestCases[i].input);
     }
     int misspelling_start;
     int misspelling_length;
     bool result = spell_checker->SpellCheckWord(
@@ skipping 253 matching lines @@
       L"th\x1EC3 truy c\x1EADp va h\x1EEFu d\x1EE5ng h\x01A1n."
     },
   };
 
   FilePath hunspell_directory = GetHunspellDirectory();
   ASSERT_FALSE(hunspell_directory.empty());
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     scoped_refptr<SpellChecker> spell_checker(new SpellChecker(
         hunspell_directory, kTestCases[i].language, NULL, FilePath()));
+    spell_checker->Initialize();
+    message_loop_.RunAllPending();
 
     size_t input_length = 0;
     if (kTestCases[i].input != NULL)
       input_length = wcslen(kTestCases[i].input);
 
     int misspelling_start = 0;
     int misspelling_length = 0;
     bool result = spell_checker->SpellCheckWord(
         WideToUTF16(kTestCases[i].input).c_str(),
         static_cast<int>(input_length),
@@ skipping 17 matching lines @@
     {L"Googleplex"},
     {L"Googler"},
   };
 
   FilePath custom_dictionary_file(kTempCustomDictionaryFile);
   FilePath hunspell_directory = GetHunspellDirectory();
   ASSERT_FALSE(hunspell_directory.empty());
 
   scoped_refptr<SpellChecker> spell_checker(new SpellChecker(
       hunspell_directory, "en-US", NULL, custom_dictionary_file));
+  spell_checker->Initialize();
+  message_loop_.RunAllPending();
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     // Add the word to spellchecker.
     spell_checker->AddWord(WideToUTF16(kTestCases[i].word_to_add));
 
     // Now check whether it is added to Spellchecker.
     std::vector<string16> suggestions;
     size_t input_length = 0;
     if (kTestCases[i].word_to_add != NULL) {
       input_length = wcslen(kTestCases[i].word_to_add);
     }
     int misspelling_start;
     int misspelling_length;
     bool result = spell_checker->SpellCheckWord(
         WideToUTF16(kTestCases[i].word_to_add).c_str(),
         static_cast<int>(input_length),
         0,
         &misspelling_start,
         &misspelling_length,
         &suggestions);
 
     // Check for spelling.
     EXPECT_TRUE(result);
   }
 
   // Now initialize another spellchecker to see that AddToWord is permanent.
   scoped_refptr<SpellChecker> spell_checker_new(new SpellChecker(
       hunspell_directory, "en-US", NULL, custom_dictionary_file));
+  spell_checker->Initialize();
+  message_loop_.RunAllPending();
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     // Now check whether it is added to Spellchecker.
     std::vector<string16> suggestions;
     size_t input_length = 0;
     if (kTestCases[i].word_to_add != NULL) {
       input_length = wcslen(kTestCases[i].word_to_add);
     }
     int misspelling_start;
     int misspelling_length;
@@ skipping 23 matching lines @@
     {L"Googleplex"},
     {L"Googler"},
   };
 
   FilePath custom_dictionary_file(kTempCustomDictionaryFile);
   FilePath hunspell_directory = GetHunspellDirectory();
   ASSERT_FALSE(hunspell_directory.empty());
 
   scoped_refptr<SpellChecker> spell_checker(new SpellChecker(
       hunspell_directory, "en-US", NULL, custom_dictionary_file));
+  spell_checker->Initialize();
+  message_loop_.RunAllPending();
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     // Add the word to spellchecker.
     spell_checker->AddWord(WideToUTF16(kTestCases[i].word_to_add));
   }
 
   // Now check to see whether the custom words are suggested for
   // misspelled but similar words.
   static const struct {
     // A string to be tested.
@@ skipping 66 matching lines @@
     {"noen", ""},
     {"what", ""},
   };
 
   FilePath hunspell_directory = GetHunspellDirectory();
   ASSERT_FALSE(hunspell_directory.empty());
 
   scoped_refptr<SpellChecker> spell_checker(new SpellChecker(
       hunspell_directory, "en-US", NULL, FilePath()));
   spell_checker->EnableAutoSpellCorrect(true);
+  spell_checker->Initialize();
+  message_loop_.RunAllPending();
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     string16 misspelled_word(UTF8ToUTF16(kTestCases[i].input));
     string16 expected_autocorrect_word(
         UTF8ToUTF16(kTestCases[i].expected_result));
     string16 autocorrect_word = spell_checker->GetAutoCorrectionWord(
         misspelled_word, 0);
 
     // Check for spelling.
     EXPECT_EQ(expected_autocorrect_word, autocorrect_word);
@@ skipping 15 matching lines @@
     {"moer", false},
     {"watre", false},
     {"noen", false},
   };
 
   FilePath hunspell_directory = GetHunspellDirectory();
   ASSERT_FALSE(hunspell_directory.empty());
 
   scoped_refptr<SpellChecker> spell_checker(new SpellChecker(
       hunspell_directory, "en-US", NULL, FilePath()));
+  spell_checker->Initialize();
+  message_loop_.RunAllPending();
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
     string16 word(UTF8ToUTF16(kTestCases[i].input));
     std::vector<string16> suggestions;
     size_t input_length = 0;
     if (kTestCases[i].input != NULL) {
       input_length = word.length();
     }
     int misspelling_start;
     int misspelling_length;
@@ skipping 33 matching lines @@
                                            doc_tag,
                                            &misspelling_start,
                                            &misspelling_length,
                                            &suggestions);
 
     // The word should now show be spelled wrong again
     EXPECT_EQ(kTestCases[i].input_result, result);
   }
 } // Test IgnoreWords_EN_US
 #endif // OS_MACOSX