Third patch in getting rid of caching MessageLoop pointers and always using C...

chrome/browser/extensions/extension_updater_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/file_util.h"
 #include "base/rand_util.h"
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
@@ skipping 56 matching lines @@
 
 // Class that contains a PrefService and handles cleanup of a temporary file
 // backing it.
 class ScopedTempPrefService {
  public:
   ScopedTempPrefService() {
     // Make sure different tests won't use the same prefs file. It will cause
     // problem when different tests are running in parallel.
     temp_dir_.CreateUniqueTempDir();
     FilePath pref_file = temp_dir_.path().AppendASCII("prefs");
-    prefs_.reset(new PrefService(pref_file, NULL));
+    prefs_.reset(new PrefService(pref_file));
   }
 
   ~ScopedTempPrefService() {}
 
   PrefService* get() {
     return prefs_.get();
   }
 
  private:
   // Ordering matters, we want |prefs_| to be destroyed before |temp_dir_|.
@@ skipping 539 matching lines @@
 // -prodversionmin (shouldn't update if browser version too old)
 // -manifests & updates arriving out of order / interleaved
 // -Profile::GetDefaultRequestContext() returning null
 //  (should not crash, but just do check later)
 // -malformed update url (empty, file://, has query, has a # fragment, etc.)
 // -An extension gets uninstalled while updates are in progress (so it doesn't
 //  "come back from the dead")
 // -An extension gets manually updated to v3 while we're downloading v2 (ie
 //  you don't get downgraded accidentally)
 // -An update manifest mentions multiple updates