Use OnPaint() to paint the content of IndicatorView.

ui/app_list/views/speech_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/speech_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_resources.h"
 #include "grit/ui_strings.h"
 #include "third_party/skia/include/core/SkPath.h"
@@ skipping 145 matching lines @@
       views::Background::CreateSolidBackground(SK_ColorWHITE));
 
   const gfx::ImageSkia& logo_image = delegate_->GetSpeechUI()->logo();
   if (!logo_image.isNull()) {
     logo_ = new views::ImageView();
     logo_->SetImage(&logo_image);
     container->AddChildView(logo_);
   }
 
   indicator_ = new SoundLevelIndicator();
-  indicator_->SetVisible(false);
-  container->AddChildView(indicator_);
 
   mic_button_ = new MicButton(this);
   container->AddChildView(mic_button_);
   mic_button_->SetEventTargeter(
       scoped_ptr<ui::EventTargeter>(new MicButtonTargeter(mic_button_)));
 
   // TODO(mukai): use BoundedLabel to cap 2 lines.
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
   speech_result_ = new views::Label(
       base::string16(), bundle.GetFontList(ui::ResourceBundle::LargeFont));
@@ skipping 61 matching lines @@
 void SpeechView::OnSpeechSoundLevelChanged(uint8 level) {
   if (!visible() ||
       delegate_->GetSpeechUI()->state() == SPEECH_RECOGNITION_NETWORK_ERROR)
     return;
 
   gfx::Point origin = mic_button_->bounds().CenterPoint();
   int radius = GetIndicatorRadius(level);
   origin.Offset(-radius, -radius + kIndicatorCenterOffsetY);
   gfx::Rect indicator_bounds =
       gfx::Rect(origin, gfx::Size(radius * 2, radius * 2));
-  if (indicator_->visible()) {
+  if (indicator_->parent()) {
     indicator_animator_->AnimateViewTo(indicator_, indicator_bounds);
   } else {
-    indicator_->SetVisible(true);
+    views::View* container = child_at(0);
+    container->AddChildViewAt(indicator_, container->GetIndexOf(mic_button_));
     indicator_->SetBoundsRect(indicator_bounds);
   }
 }
 
 void SpeechView::OnSpeechResult(const base::string16& result,
                                 bool is_final) {
   speech_result_->SetText(result);
   speech_result_->SetEnabledColor(kResultTextColor);
 }
 
 void SpeechView::OnSpeechRecognitionStateChanged(
     SpeechRecognitionState new_state) {
   int resource_id = IDR_APP_LIST_SPEECH_MIC_OFF;
   if (new_state == SPEECH_RECOGNITION_RECOGNIZING)
     resource_id = IDR_APP_LIST_SPEECH_MIC_ON;
   else if (new_state == SPEECH_RECOGNITION_IN_SPEECH)
     resource_id = IDR_APP_LIST_SPEECH_MIC_RECORDING;
 
   int text_resource_id = IDS_APP_LIST_SPEECH_HINT_TEXT;
 
   if (new_state == SPEECH_RECOGNITION_NETWORK_ERROR) {
     text_resource_id = IDS_APP_LIST_SPEECH_NETWORK_ERROR_HINT_TEXT;
-    indicator_->SetVisible(false);

[xiyuan, 2014/06/18 23:13:05]

Would a "indicator_->SchedulePaint()" here help?

[Jun Mukai, 2014/06/18 23:13:51]

I tried SchedulePaint but it didn't help.

[xiyuan, 2014/06/18 23:16:02]

Try put it before "indicator_->SetVisible(false);" or call parent's
SchedulePaint? It seems SchedulePaint is a noop if visible_ is false.

[Jun Mukai, 2014/06/19 00:58:14]

Tried all pattern of SchedulePaint(), child_at(0)->SchedulePaint(),
indicator_->SchedulePaint(), before and after SetVisible, and nothing helps.

[Jun Mukai, 2014/06/19 01:00:57]

Ah, I think I've found why.  indicator_animator_ may control the location and
something *after* this visibility change. Let me check this.

[Jun Mukai, 2014/06/19 02:20:15]

Turns out I was totally pointless :(
Everything was actually fine, we do not even need additional SchedulePaint().
The problem is that IndicatorView overrides Paint() method.  Paint() has long
and common logic including the visibility check, and calls several painting
methods.  In this purpose, overriding Paint() is a bad idea, OnPaint() is
better.

Uploaded a new patchset for this. PTAL.

+    child_at(0)->RemoveChildView(indicator_);
   }
   speech_result_->SetText(l10n_util::GetStringUTF16(text_resource_id));
   speech_result_->SetEnabledColor(kHintTextColor);
 
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
   mic_button_->SetImage(views::Button::STATE_NORMAL,
                         bundle.GetImageSkiaNamed(resource_id));
 }
 
 }  // namespace app_list