Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3891)

Unified Diff: chrome/browser/google/google_search_counter.h

Issue 342053002: Add UMA metrics for Android Chrome Google Search. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chrome/browser/google/google_search_counter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_search_counter.h
diff --git a/chrome/browser/google/google_search_counter.h b/chrome/browser/google/google_search_counter.h
index be60c6a891a9b0a98e3f284880c9e49066e578fa..22751bd85aebf978fd1971cc804e888f358f2526 100644
--- a/chrome/browser/google/google_search_counter.h
+++ b/chrome/browser/google/google_search_counter.h
@@ -10,6 +10,10 @@
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+namespace content {
+class NavigationEntry;
+}
+
// A listener for counting Google searches from various search access points. No
// actual search query content is observed. See GoogleSearchMetrics for more
// details about these access points.
@@ -21,6 +25,21 @@ class GoogleSearchCounter : content::NotificationObserver {
// Return the singleton instance of GoogleSearchCounter.
static GoogleSearchCounter* GetInstance();
+ // Returns the Google search access point for the given |entry|. This method
+ // assumes that we have already verified that |entry|'s URL is a Google search
+ // URL.
+ GoogleSearchMetrics::AccessPoint GetGoogleSearchAccessPointForSearchNavEntry(
+ const content::NavigationEntry& entry) const;
+
+ // Returns true if |details| is valid and corresponds to a search results
+ // page.
+ bool ShouldRecordCommittedDetails(
+ const content::NotificationDetails& details) const;
+
+ const GoogleSearchMetrics* search_metrics() const {
+ return search_metrics_.get();
+ }
+
private:
friend struct DefaultSingletonTraits<GoogleSearchCounter>;
friend class GoogleSearchCounterTest;
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chrome/browser/google/google_search_counter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698