Add UMA metrics for Android Chrome Google Search.

chrome/browser/google/google_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google/google_util.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/google/core/browser/google_switches.h"
 #include "components/google/core/browser/google_url_tracker.h"
 #include "components/url_fixer/url_fixer.h"
+#include "content/public/browser/navigation_entry.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/base/url_util.h"
 #include "url/gurl.h"
 
 // Only use Link Doctor on official builds.  It uses an API key, too, but
 // seems best to just disable it, for more responsive error pages and to reduce
 // server load.
 #if defined(GOOGLE_CHROME_BUILD)
 #define LINKDOCTOR_SERVER_REQUEST_URL "https://www.googleapis.com/rpc"
 #else
@@ skipping 178 matching lines @@
       (!is_home_page_base && HasGoogleSearchQueryParam(url.query()));
 }
 
 bool IsYoutubeDomainUrl(const GURL& url,
                         SubdomainPermission subdomain_permission,
                         PortPermission port_permission) {
   return IsValidURL(url, port_permission) &&
       IsValidHostName(url.host(), "youtube", subdomain_permission);
 }
 
+GoogleSearchMetrics::AccessPoint GetGoogleSearchAccessPointForSearchNavEntry(
+    const content::NavigationEntry& entry) {
+  DCHECK(google_util::IsGoogleSearchUrl(entry.GetURL()));
+
+  // If the commit is a GENERATED commit with a Google search URL, we know it's
+  // an Omnibox search.

[Peter Kasting, 2014/06/20 01:23:18]

Nit: This comment isn't quite accurate to the code.  How about:

If the entry is FROM_ADDRESS_BAR, it comes from the omnibox; if it's GENERATED,
the user was doing a search, rather than doing a navigation to a search URL
(e.g. from history, or pasted in).

[kmadhusu, 2014/06/20 01:40:51]

Done.

+  if (entry.GetTransitionType() == (content::PAGE_TRANSITION_GENERATED |
+      content::PAGE_TRANSITION_FROM_ADDRESS_BAR)) {
+    return GoogleSearchMetrics::AP_OMNIBOX;
+  }
+
+  // The string "source=search_app" in the |entry| URL represents a Google
+  // search from the Google Search App. For all other cases that we have not yet
+  // implemented or care to measure, we log a generic "catch-all" metric.
+  return (entry.GetURL().query().find("source=search_app") !=
+      std::string::npos) ? GoogleSearchMetrics::AP_SEARCH_APP :
+          GoogleSearchMetrics::AP_OTHER;

[Peter Kasting, 2014/06/20 01:23:19]

Nit: I think this would be more readable split up:

  // The string "source=search_app" in the |entry| URL represents a Google
  // search from the Google Search App.
  if (entry.GetURL().query().find("source=search_app") != std::string::npos)
    return GoogleSearchMetrics::AP_SEARCH_APP;

  // For all other cases that we have not yet implemented or care to measure, we
  // log a generic "catch-all" metric.
  return GoogleSearchMetrics::AP_OTHER;

[kmadhusu, 2014/06/20 01:40:51]

Done.

+}
+
 }  // namespace google_util