Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: chrome/browser/views/find_bar_host_interactive_uitest.cc

Issue 342038: Disable FindInPageTest.FocusRestore, which is killing the Interactive Tests bot (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/keyboard_codes.h" 5 #include "base/keyboard_codes.h"
6 #include "base/message_loop.h" 6 #include "base/message_loop.h"
7 #include "chrome/browser/automation/ui_controls.h" 7 #include "chrome/browser/automation/ui_controls.h"
8 #include "chrome/browser/browser.h" 8 #include "chrome/browser/browser.h"
9 #include "chrome/browser/browser_window.h" 9 #include "chrome/browser/browser_window.h"
10 #include "chrome/browser/find_bar_controller.h" 10 #include "chrome/browser/find_bar_controller.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID()); 103 EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID());
104 #endif 104 #endif
105 105
106 // This used to crash until bug 1303709 was fixed. 106 // This used to crash until bug 1303709 was fixed.
107 ui_controls::SendKeyPressNotifyWhenDone( 107 ui_controls::SendKeyPressNotifyWhenDone(
108 browser()->window()->GetNativeHandle(), base::VKEY_ESCAPE, 108 browser()->window()->GetNativeHandle(), base::VKEY_ESCAPE,
109 true, false, false, new MessageLoop::QuitTask()); 109 true, false, false, new MessageLoop::QuitTask());
110 ui_test_utils::RunMessageLoop(); 110 ui_test_utils::RunMessageLoop();
111 } 111 }
112 112
113 IN_PROC_BROWSER_TEST_F(FindInPageTest, FocusRestore) { 113 // TODO: http://crbug.com/26231
114 IN_PROC_BROWSER_TEST_F(FindInPageTest, DISABLED_FocusRestore) {
114 scoped_refptr<HTTPTestServer> server = 115 scoped_refptr<HTTPTestServer> server =
115 HTTPTestServer::CreateServer(kDocRoot, NULL); 116 HTTPTestServer::CreateServer(kDocRoot, NULL);
116 ASSERT_TRUE(NULL != server.get()); 117 ASSERT_TRUE(NULL != server.get());
117 118
118 GURL url = server->TestServerPageW(L"title1.html"); 119 GURL url = server->TestServerPageW(L"title1.html");
119 ui_test_utils::NavigateToURL(browser(), url); 120 ui_test_utils::NavigateToURL(browser(), url);
120 121
121 // Focus the location bar, open and close the find-in-page, focus should 122 // Focus the location bar, open and close the find-in-page, focus should
122 // return to the location bar. 123 // return to the location bar.
123 browser()->FocusLocationBar(); 124 browser()->FocusLocationBar();
(...skipping 16 matching lines...) Expand all
140 // Focus the location bar, open and close the find box, focus should return to 141 // Focus the location bar, open and close the find box, focus should return to
141 // the location bar (same as before, just checking that http://crbug.com/23599 142 // the location bar (same as before, just checking that http://crbug.com/23599
142 // is fixed). 143 // is fixed).
143 browser()->FocusLocationBar(); 144 browser()->FocusLocationBar();
144 EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID()); 145 EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID());
145 browser()->find_bar()->Show(); 146 browser()->find_bar()->Show();
146 EXPECT_EQ(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD, GetFocusedViewID()); 147 EXPECT_EQ(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD, GetFocusedViewID());
147 browser()->find_bar()->EndFindSession(); 148 browser()->find_bar()->EndFindSession();
148 EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID()); 149 EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID());
149 } 150 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698