Issue 342030: Add a dump-file option to process_dumps_linux.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342030: Add a dump-file option to process_dumps_linux.py (Closed)

Created:
11 years, 1 month ago by huanr

Modified:
9 years ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a dump-file option to process_dumps_linux.py TEST=run process_dumps_linux.py with --dump-file option. BUG=22265 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30404

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -12 lines)			Patch
	M	chrome/tools/process_dumps_linux.py	View		3 chunks	+22 lines, -12 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

11 years, 1 month ago (2009-10-28 23:17:25 UTC) #2

LGTM

http://codereview.chromium.org/342030/diff/2001/3001
File chrome/tools/process_dumps_linux.py (right):

http://codereview.chromium.org/342030/diff/2001/3001#newcode275
Line 275: 'Searches this directory if dump-file is not'
nit, you need an extra space after not.

Expand Messages | Collapse Messages