Issue 342003007: [Cast] Correct serialization of packet sequence number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342003007: [Cast] Correct serialization of packet sequence number. (Closed)

Created:
6 years, 6 months ago by miu

Modified:
6 years, 6 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Cast] Correct serialization of packet sequence number. Code that modifies an already-serialized packet was erroneously writing out a 16-bit value using little-endian byte order. This change corrects that to be written big-endian, per the spec. BUG=385894 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278335

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	media/cast/transport/rtp_sender/rtp_sender.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/342003007/1

6 years, 6 months ago (2014-06-19 02:08:06 UTC) #3

Message was sent while issue was closed.

Change committed as 278335

Expand Messages | Collapse Messages