Turn 'browser' app into a 'launcher_ui' app that window_manager embeds.

Turn 'browser' app into a 'launcher' app that window_manager
embeds. This also adds the 'RequestNavigate' part of the
navigation protocol.

I will rename the mojo_browser target and related names to
mojo_launcher_ui in a separate CL.

This depends on https://codereview.chromium.org/331323007/.

BUG=386275
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278312

[Ben Goodger (Google), 2014-06-19 02:48:44]

lgtm. i will tweak some of the views usage in here once you're done with this &
have moved it where you want it to go.

https://codereview.chromium.org/342003006/diff/40001/mojo/examples/browser/br...
File mojo/examples/browser/browser.cc (right):

https://codereview.chromium.org/342003006/diff/40001/mojo/examples/browser/br...
mojo/examples/browser/browser.cc:28: class NodeView : public views::View {
i think you can delete this class now too

https://codereview.chromium.org/342003006/diff/40001/mojo/examples/browser/br...
mojo/examples/browser/browser.cc:130:
navigator_host_->RequestNavigate(view_manager_->GetRoots().front()->id(),
cool!

https://codereview.chromium.org/342003006/diff/40001/mojo/examples/browser/br...
mojo/examples/browser/browser.cc:138: // Ghetto workaround for crbug.com/386256.
lol

[darin (slow to review), 2014-06-19 03:28:43]

It occurs to me that "Navigator" might also be a good name for this thing
;-)

-Darin


On Wed, Jun 18, 2014 at 7:48 PM, <ben@chromium.org> wrote:

> lgtm. i will tweak some of the views usage in here once you're done with
> this &
> have moved it where you want it to go.
>
>
> https://codereview.chromium.org/342003006/diff/40001/mojo/
> examples/browser/browser.cc
> File mojo/examples/browser/browser.cc (right):
>
> https://codereview.chromium.org/342003006/diff/40001/mojo/
> examples/browser/browser.cc#newcode28
> mojo/examples/browser/browser.cc:28: class NodeView : public views::View
> {
> i think you can delete this class now too
>
> https://codereview.chromium.org/342003006/diff/40001/mojo/
> examples/browser/browser.cc#newcode130
> mojo/examples/browser/browser.cc:130:
> navigator_host_->RequestNavigate(view_manager_->GetRoots().front()->id(),
> cool!
>
> https://codereview.chromium.org/342003006/diff/40001/mojo/
> examples/browser/browser.cc#newcode138
> mojo/examples/browser/browser.cc:138: // Ghetto workaround for
> crbug.com/386256.
> lol
>
> https://codereview.chromium.org/342003006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Aaron Boodman, 2014-06-19 05:07:10]

Yeah, I was considering that...

I wasn't sure, since it seems like maybe the search UI, which is really
what this is, is separable from the history stack and navigation. Maybe
navigation/history is yet another application, and *that* is called
navigator...


On Wed, Jun 18, 2014 at 8:28 PM, Darin Fisher <darin@chromium.org> wrote:

> It occurs to me that "Navigator" might also be a good name for this thing
> ;-)
>
> -Darin
>
>
> On Wed, Jun 18, 2014 at 7:48 PM, <ben@chromium.org> wrote:
>
>> lgtm. i will tweak some of the views usage in here once you're done with
>> this &
>> have moved it where you want it to go.
>>
>>
>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>> examples/browser/browser.cc
>> File mojo/examples/browser/browser.cc (right):
>>
>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>> examples/browser/browser.cc#newcode28
>> mojo/examples/browser/browser.cc:28: class NodeView : public views::View
>> {
>> i think you can delete this class now too
>>
>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>> examples/browser/browser.cc#newcode130
>> mojo/examples/browser/browser.cc:130:
>> navigator_host_->RequestNavigate(view_manager_->GetRoots().front()->id(),
>> cool!
>>
>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>> examples/browser/browser.cc#newcode138
>> mojo/examples/browser/browser.cc:138: // Ghetto workaround for
>> crbug.com/386256.
>> lol
>>
>> https://codereview.chromium.org/342003006/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[darin (slow to review), 2014-06-19 05:11:40]

Ah, I had assumed this would grow that functionality.

-Darin


On Wed, Jun 18, 2014 at 10:06 PM, Aaron Boodman <aa@chromium.org> wrote:

> Yeah, I was considering that...
>
> I wasn't sure, since it seems like maybe the search UI, which is really
> what this is, is separable from the history stack and navigation. Maybe
> navigation/history is yet another application, and *that* is called
> navigator...
>
>
> On Wed, Jun 18, 2014 at 8:28 PM, Darin Fisher <darin@chromium.org> wrote:
>
>> It occurs to me that "Navigator" might also be a good name for this thing
>> ;-)
>>
>> -Darin
>>
>>
>> On Wed, Jun 18, 2014 at 7:48 PM, <ben@chromium.org> wrote:
>>
>>> lgtm. i will tweak some of the views usage in here once you're done with
>>> this &
>>> have moved it where you want it to go.
>>>
>>>
>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>> examples/browser/browser.cc
>>> File mojo/examples/browser/browser.cc (right):
>>>
>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>> examples/browser/browser.cc#newcode28
>>> mojo/examples/browser/browser.cc:28: class NodeView : public views::View
>>> {
>>> i think you can delete this class now too
>>>
>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>> examples/browser/browser.cc#newcode130
>>> mojo/examples/browser/browser.cc:130:
>>> navigator_host_->RequestNavigate(view_manager_-
>>> >GetRoots().front()->id(),
>>> cool!
>>>
>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>> examples/browser/browser.cc#newcode138
>>> mojo/examples/browser/browser.cc:138: // Ghetto workaround for
>>> crbug.com/386256.
>>> lol
>>>
>>> https://codereview.chromium.org/342003006/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Aaron Boodman, 2014-06-19 06:20:07]

https://codereview.chromium.org/342003006/diff/40001/mojo/examples/browser/br...
File mojo/examples/browser/browser.cc (right):

https://codereview.chromium.org/342003006/diff/40001/mojo/examples/browser/br...
mojo/examples/browser/browser.cc:28: class NodeView : public views::View {
On 2014/06/19 02:48:44, Ben Goodger (Google) wrote:
> i think you can delete this class now too

Done.

[Aaron Boodman, 2014-06-19 06:20:36]

The CQ bit was checked by aa@chromium.org

[Aaron Boodman, 2014-06-19 06:20:40]

The CQ bit was unchecked by aa@chromium.org

[Aaron Boodman, 2014-06-19 06:20:41]

The CQ bit was checked by aa@chromium.org

[commit-bot: I haz the power, 2014-06-19 06:22:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aa@chromium.org/342003006/60001

[Aaron Boodman, 2014-06-19 09:14:21]

Committed patchset #2 manually as r278312 (presubmit successful).

[Aaron Boodman, 2014-06-19 09:58:06]

You know on second thought, 'browser' isn't such a bad name for this. It's
not the way we usually use the word 'browser', but it's just as accurate as
'navigator'. I think I will leave it as 'browser' for now.

I'm not crazy about using 'navigator' here because we also have the system
interfaces Navigator and NavigatorHost and there could be confusion that
the service is related to those interfaces more closely than it actually is.

- a


On Wed, Jun 18, 2014 at 10:11 PM, Darin Fisher <darin@chromium.org> wrote:

> Ah, I had assumed this would grow that functionality.
>
> -Darin
>
>
> On Wed, Jun 18, 2014 at 10:06 PM, Aaron Boodman <aa@chromium.org> wrote:
>
>> Yeah, I was considering that...
>>
>> I wasn't sure, since it seems like maybe the search UI, which is really
>> what this is, is separable from the history stack and navigation. Maybe
>> navigation/history is yet another application, and *that* is called
>> navigator...
>>
>>
>> On Wed, Jun 18, 2014 at 8:28 PM, Darin Fisher <darin@chromium.org> wrote:
>>
>>> It occurs to me that "Navigator" might also be a good name for this
>>> thing ;-)
>>>
>>> -Darin
>>>
>>>
>>> On Wed, Jun 18, 2014 at 7:48 PM, <ben@chromium.org> wrote:
>>>
>>>> lgtm. i will tweak some of the views usage in here once you're done
>>>> with this &
>>>> have moved it where you want it to go.
>>>>
>>>>
>>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>>> examples/browser/browser.cc
>>>> File mojo/examples/browser/browser.cc (right):
>>>>
>>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>>> examples/browser/browser.cc#newcode28
>>>> mojo/examples/browser/browser.cc:28: class NodeView : public
>>>> views::View
>>>> {
>>>> i think you can delete this class now too
>>>>
>>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>>> examples/browser/browser.cc#newcode130
>>>> mojo/examples/browser/browser.cc:130:
>>>> navigator_host_->RequestNavigate(view_manager_-
>>>> >GetRoots().front()->id(),
>>>> cool!
>>>>
>>>> https://codereview.chromium.org/342003006/diff/40001/mojo/
>>>> examples/browser/browser.cc#newcode138
>>>> mojo/examples/browser/browser.cc:138: // Ghetto workaround for
>>>> crbug.com/386256.
>>>> lol
>>>>
>>>> https://codereview.chromium.org/342003006/
>>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.