chrome/browser/extensions/unpacked_installer.h - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.h

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed patch set 4 comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | chrome/browser/resources/extensions/extension_loader.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.h

diff --git a/chrome/browser/extensions/unpacked_installer.h b/chrome/browser/extensions/unpacked_installer.h

index fc22e3c92b460b7b2ae29dbb94c68c1d521045f6..9a93006eaf81a2e44b754656103375772080921c 100644

--- a/chrome/browser/extensions/unpacked_installer.h

+++ b/chrome/browser/extensions/unpacked_installer.h

@@ -65,10 +65,6 @@ class UnpackedInstaller

require_modern_manifest_version_ = val;

}

- void set_on_failure_callback(const OnFailureCallback& callback) {

- on_failure_callback_ = callback;

- }

void set_be_noisy_on_failure(bool be_noisy_on_failure) {

be_noisy_on_failure_ = be_noisy_on_failure;

}

@@ -129,9 +125,6 @@ class UnpackedInstaller

// version.

bool require_modern_manifest_version_;

- // An optional callback to set in order to be notified of failure.

- OnFailureCallback on_failure_callback_;

// Whether or not to be noisy (show a dialog) on failure. Defaults to true.

bool be_noisy_on_failure_;