Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synchronized page loading, support multiple load errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 0c1e66d9c785a31faa1c6e6ca3625cafc1998ccc..8fa951415505f5eed959912ca40f8a35108977ed 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -15,6 +15,14 @@
<include src="chromeos/kiosk_apps.js"></include>
</if>
+document.addEventListener('DOMContentLoaded', function() {
Devlin 2014/06/27 22:31:08 ExtensionLoader should have as few dependencies on
gpdavis 2014/06/27 23:42:54 I'll give that a try and see if it works the same.
gpdavis 2014/06/28 02:31:17 Looks good! Done.
+ chrome.send('extensionLoaderDisplayFailures');
Devlin 2014/06/27 22:31:09 nit: indentation.
gpdavis 2014/06/28 02:31:17 Done.
+});
+
+window.addEventListener('beforeunload', function() {
Devlin 2014/06/27 22:31:09 nit: indentation.
gpdavis 2014/06/28 02:31:17 Done.
+ chrome.send('extensionLoaderSetDisplayLoading');
+});
+
// Used for observing function of the backend datasource for this page by
// tests.
var webuiResponded = false;

Powered by Google App Engine
This is Rietveld 408576698