Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2846)

Unified Diff: chrome/browser/resources/extensions/extension_loader.js

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synchronized page loading, support multiple load errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_loader.js
diff --git a/chrome/browser/resources/extensions/extension_loader.js b/chrome/browser/resources/extensions/extension_loader.js
index fb57c18b139075cba35b00c733df28187052c4c9..e4d1ac0a2ced645d67231a3524ee0ac039039bed 100644
--- a/chrome/browser/resources/extensions/extension_loader.js
+++ b/chrome/browser/resources/extensions/extension_loader.js
@@ -37,6 +37,9 @@ cr.define('extensions', function() {
*/
this.reason_ = this.querySelector('#extension-load-error-reason');
+ this.additional_ =
Devlin 2014/06/27 22:31:08 comments.
gpdavis 2014/06/28 02:31:17 Done.
+ this.querySelector('#extension-load-error-additional-list');
+
/**
* The element which displays the manifest code.
* @type {ExtensionCode}
@@ -75,6 +78,10 @@ cr.define('extensions', function() {
this.manifest_.scrollToError();
},
+ showAdditional: function(failures) {
Devlin 2014/06/27 22:31:08 comments.
gpdavis 2014/06/28 02:31:17 Done.
+ this.additional_.textContent = failures;
+ },
+
/**
* Hide the extension load error.
* @private
@@ -122,6 +129,10 @@ cr.define('extensions', function() {
*/
notifyFailed: function(filePath, reason, manifest) {
this.loadError_.show(filePath, reason, manifest);
+ },
+
+ notifyAdditionalFailures: function(failures) {
Devlin 2014/06/27 22:31:08 comments.
gpdavis 2014/06/28 02:31:17 Done.
+ this.loadError_.showAdditional(failures);
}
};
@@ -136,6 +147,10 @@ cr.define('extensions', function() {
ExtensionLoader.getInstance().notifyFailed(filePath, reason, manifest);
};
+ ExtensionLoader.notifyAdditional = function(failures) {
Devlin 2014/06/27 22:31:08 comments.
gpdavis 2014/06/28 02:31:17 Done.
+ ExtensionLoader.getInstance().notifyAdditionalFailures(failures);
+ };
+
return {
ExtensionLoader: ExtensionLoader
};

Powered by Google App Engine
This is Rietveld 408576698