Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3576)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pointer scope, page loading notification, other minor changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 49b259f57c41cf5ae64682042972db64963ae4be..d7d7514e624094b78e2e1250b3a1878f408e3476 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -781,7 +781,7 @@ void ExtensionSettingsHandler::ReloadUnpackedExtensions() {
for (std::vector<const Extension*>::iterator iter =
unpacked_extensions.begin(); iter != unpacked_extensions.end(); ++iter) {
- extension_service_->ReloadExtension((*iter)->id());
+ extension_service_->ReloadExtensionWithQuietFailure((*iter)->id());
}
}
@@ -933,7 +933,7 @@ void ExtensionSettingsHandler::HandleReloadMessage(
const base::ListValue* args) {
std::string extension_id = base::UTF16ToUTF8(ExtractStringValue(args));
CHECK(!extension_id.empty());
- extension_service_->ReloadExtension(extension_id);
+ extension_service_->ReloadExtensionWithQuietFailure(extension_id);
}
void ExtensionSettingsHandler::HandleEnableMessage(

Powered by Google App Engine
This is Rietveld 408576698