chrome/browser/resources/extensions/extension_load_error.html - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_load_error.html

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added ReloadExtensionImpl, enhanced loader handler to send ListValue of failures Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.h ('K') | « chrome/browser/extensions/unpacked_installer.cc ('k') | chrome/browser/resources/extensions/extension_loader.js » ('j') | chrome/browser/resources/extensions/extension_loader.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_load_error.html

diff --git a/chrome/browser/resources/extensions/extension_load_error.html b/chrome/browser/resources/extensions/extension_load_error.html

index ce78dbcf745356367bf5a0f55da957ec488ea035..6d3b4a506c48344e54b8b6d58256d21ae61be766 100644

--- a/chrome/browser/resources/extensions/extension_load_error.html

+++ b/chrome/browser/resources/extensions/extension_load_error.html

@@ -18,4 +18,7 @@ in the LICENSE file.

<button id="extension-load-error-give-up-button"

i18n-content="extensionLoadErrorGiveUp"></button>

</div>

+ <div>

Devlin 2014/07/07 20:44:21 Why is the div visible at all, if the only child i

gpdavis 2014/07/09 01:35:56 Replaced with list. Done.

+ <pre id="extension-load-error-additional" hidden></pre>

+ </div>

</div>