chrome/browser/extensions/chrome_extension_web_contents_observer.cc - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_web_contents_observer.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved path handling back to C++ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/background/background_contents_service.cc ('K') | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | chrome/browser/resources/extensions/extension_loader.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_web_contents_observer.cc

diff --git a/chrome/browser/extensions/chrome_extension_web_contents_observer.cc b/chrome/browser/extensions/chrome_extension_web_contents_observer.cc

index cc310739fecde548e026c8481f42595d0fb21c1a..f3db44caaadd19e0e5df2bd140edd61be4618ece 100644

--- a/chrome/browser/extensions/chrome_extension_web_contents_observer.cc

+++ b/chrome/browser/extensions/chrome_extension_web_contents_observer.cc

@@ -113,7 +113,7 @@ void ChromeExtensionWebContentsObserver::ReloadIfTerminated(

// We should delay loading until the extension has reloaded.

if (registry->GetExtensionById(extension_id, ExtensionRegistry::TERMINATED)) {

ExtensionSystem::Get(browser_context())->

- extension_service()->ReloadExtension(extension_id);

+ extension_service()->ReloadExtension(extension_id, true);

}