Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7087)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed be_noisy, support interaction with multiple failures Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 1a14db7c8bf9934f6234fac1b787ad0c84231cbe..19588e3e0d9bd2ada347bf1ea7783c4c4c267f03 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -773,7 +773,7 @@ void ExtensionSettingsHandler::ReloadUnpackedExtensions() {
for (std::vector<const Extension*>::iterator iter =
unpacked_extensions.begin(); iter != unpacked_extensions.end(); ++iter) {
- extension_service_->ReloadExtension((*iter)->id());
+ extension_service_->ReloadExtension((*iter)->id(), false);
}
}
@@ -925,7 +925,7 @@ void ExtensionSettingsHandler::HandleReloadMessage(
const base::ListValue* args) {
std::string extension_id = base::UTF16ToUTF8(ExtractStringValue(args));
CHECK(!extension_id.empty());
- extension_service_->ReloadExtension(extension_id);
+ extension_service_->ReloadExtension(extension_id, false);
}
void ExtensionSettingsHandler::HandleEnableMessage(

Powered by Google App Engine
This is Rietveld 408576698