Show alert failure for reloading unpacked extensions with bad manifest

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js"></include>
 <include src="extension_code.js"></include>
 <include src="extension_commands_overlay.js"></include>
 <include src="extension_focus_manager.js"></include>
 <include src="extension_list.js"></include>
 <include src="pack_extension_overlay.js"></include>
 <include src="extension_error_overlay.js"></include>
 <include src="extension_loader.js"></include>
 
 <if expr="chromeos">
 <include src="chromeos/kiosk_apps.js"></include>
 </if>
 
+document.addEventListener('DOMContentLoaded', function() {

[Devlin, 2014/06/27 22:31:08]

ExtensionLoader should have as few dependencies on things like full
extensions.js as possible.  Why not notify from the ExtensionLoader js class?

[gpdavis, 2014/06/27 23:42:54]

I'll give that a try and see if it works the same.  My idea for this was to send
the proper signals that tell the error reporter whether the UI is ready to
receive these error messages.

[gpdavis, 2014/06/28 02:31:17]

Looks good!

Done.

+    chrome.send('extensionLoaderDisplayFailures');

[Devlin, 2014/06/27 22:31:09]

nit: indentation.

[gpdavis, 2014/06/28 02:31:17]

Done.

+});
+
+window.addEventListener('beforeunload', function() {

[Devlin, 2014/06/27 22:31:09]

nit: indentation.

[gpdavis, 2014/06/28 02:31:17]

Done.

+    chrome.send('extensionLoaderSetDisplayLoading');
+});
+
 // Used for observing function of the backend datasource for this page by
 // tests.
 var webuiResponded = false;
 
 cr.define('extensions', function() {
   var ExtensionsList = options.ExtensionsList;
 
   // Implements the DragWrapper handler interface.
   var dragWrapperHandler = {
     /** @override */
@@ skipping 406 matching lines @@
 
   // Export
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 window.addEventListener('load', function(e) {
   extensions.ExtensionSettings.getInstance().initialize();
 });