Show alert failure for reloading unpacked extensions with bad manifest

chrome/browser/resources/extensions/extension_loader.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('extensions', function() {
   'use strict';
 
   /**
    * Construct an ExtensionLoadError around the given |div|.
    * @param {HTMLDivElement} div The HTML div for the extension load error.
@@ skipping 19 matching lines @@
        */
       this.path_ = this.querySelector('#extension-load-error-path');
 
       /**
        * The element which displays the reason the extension failed to load.
        * @type {HTMLSpanElement}
        * @private
        */
       this.reason_ = this.querySelector('#extension-load-error-reason');
 
+      this.additional_ =

[Devlin, 2014/06/27 22:31:08]

comments.

[gpdavis, 2014/06/28 02:31:17]

Done.

+          this.querySelector('#extension-load-error-additional-list');
+
       /**
        * The element which displays the manifest code.
        * @type {ExtensionCode}
        * @private
        */
       this.manifest_ = new extensions.ExtensionCode(
           this.querySelector('#extension-load-error-manifest'));
 
       this.querySelector('#extension-load-error-retry-button').addEventListener(
           'click', function(e) {
@@ skipping 18 matching lines @@
       this.reason_.textContent = reason;
 
       manifest.message = reason;
       this.manifest_.populate(
           manifest,
           loadTimeData.getString('extensionLoadCouldNotLoadManifest'));
       this.hidden = false;
       this.manifest_.scrollToError();
     },
 
+    showAdditional: function(failures) {

[Devlin, 2014/06/27 22:31:08]

comments.

[gpdavis, 2014/06/28 02:31:17]

Done.

+      this.additional_.textContent = failures;
+    },
+
     /**
      * Hide the extension load error.
      * @private
      */
     hide_: function() {
       this.hidden = true;
     }
   };
 
   /**
@@ skipping 27 matching lines @@
      * @param {string} filePath The path to the unpacked extension.
      * @param {string} reason The reason the extension failed to load.
      * @param {Object} manifest An object with three strings: beforeHighlight,
      *     afterHighlight, and highlight. These represent three portions of the
      *     file's content to display - the portion which is most relevant and
      *     should be emphasized (highlight), and the parts both before and after
      *     this portion. These may be empty.
      */
     notifyFailed: function(filePath, reason, manifest) {
       this.loadError_.show(filePath, reason, manifest);
+    },
+
+    notifyAdditionalFailures: function(failures) {

[Devlin, 2014/06/27 22:31:08]

comments.

[gpdavis, 2014/06/28 02:31:17]

Done.

+      this.loadError_.showAdditional(failures);
     }
   };
 
   /*
    * A static forwarding function for ExtensionLoader.notifyFailed.
    * @param {string} filePath The path to the unpacked extension.
    * @param {string} reason The reason the extension failed to load.
    * @param {Object} manifest The manifest of the failed extension.
    * @see ExtensionLoader.notifyFailed
    */
   ExtensionLoader.notifyLoadFailed = function(filePath, reason, manifest) {
     ExtensionLoader.getInstance().notifyFailed(filePath, reason, manifest);
   };
 
+  ExtensionLoader.notifyAdditional = function(failures) {

[Devlin, 2014/06/27 22:31:08]

comments.

[gpdavis, 2014/06/28 02:31:17]

Done.

+    ExtensionLoader.getInstance().notifyAdditionalFailures(failures);
+  };
+
   return {
     ExtensionLoader: ExtensionLoader
   };
 });